RedundantParens: detect enclosed trees properly #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The updated scalameta parser now correctly determines it's not valid. Also add a few extra tests.
This now allows us to use a single approach which is no longer overly sensitive to whether the scalameta parser includes the parentheses as part of the enclosed or enclosing tree.
tgodzik
approved these changes
May 12, 2022
|
@xuwei-k @armanbilge thanks for the examples |
This was referenced May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now allows us to use a single approach which is no longer overly sensitive to whether the scalameta parser includes the parentheses as part of the enclosed or enclosing tree. Required for #3200.