FormatWriter: generalize alignment of infix exprs #3375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbellew
changed the title
tgodzik
approved these changes
Nov 14, 2022
tgodzik
approved these changes
Nov 14, 2022
| foooooo % barrrr % | ||
| bazz % | ||
| "test", | ||
| foo %%% bar % baz % "test" |
There was a problem hiding this comment.
Shouldn't %%% be aligned also?
Suggested change
| foo %%% bar % baz % "test" | |
| foo %%% bar % baz % "test" |
There was a problem hiding this comment.
not really, since the multiline last expression has interrupted the sequence of aligned lines.
There was a problem hiding this comment.
also, as you could see, the code change didn't change the outcome of the tests, which is why they were added: to prove nothing changes.
There was a problem hiding this comment.
makes sense! I was mostly wondering what the behaviour should be in that case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.