Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to run ScalaPB outside SBT #17

Closed
thesamet opened this issue Apr 10, 2015 · 10 comments
Closed

Make it possible to run ScalaPB outside SBT #17

thesamet opened this issue Apr 10, 2015 · 10 comments

Comments

@thesamet
Copy link
Contributor

No description provided.

@ahjohannessen
Copy link
Contributor

@thesamet Have you guys seen this: https://github.com/os72/protoc-jar ?

@nadavsr
Copy link
Contributor

nadavsr commented Apr 29, 2015

@ahjohannessen This looks really useful. Thanks!

@ahjohannessen
Copy link
Contributor

@nadavsr Yep, that could eliminate the need to have a install_protobuf.sh for CI and utilize dependency caching and faster CI builds, as well :-)

@ahjohannessen
Copy link
Contributor

@nadavsr @thesamet Would it be possible that you guys upgrade to sbt-protobuf 0.4.0: https://github.com/sbt/sbt-protobuf/blob/master/notes/0.4.0.markdown

It has ability to run protoc-jar as issue sbt/sbt-protobuf#23 is closed.

@thesamet
Copy link
Contributor Author

thesamet commented May 7, 2015

Yes, this is planned to happen soon.

On Thu, May 7, 2015 at 4:16 AM, Alex Henning Johannessen <
notifications@github.com> wrote:

@nadavsr https://github.com/nadavsr @thesamet
https://github.com/thesamet Would it be possible that you guys upgrade
to sbt-protobuf 0.4.0:
https://github.com/sbt/sbt-protobuf/blob/master/notes/0.4.0.markdown

It has ability to run protoc-jar as issue sbt/sbt-protobuf#23
sbt/sbt-protobuf#23 is closed.


Reply to this email directly or view it on GitHub
#17 (comment).

-Nadav

thesamet added a commit that referenced this issue May 7, 2015
@thesamet
Copy link
Contributor Author

thesamet commented May 8, 2015

I've built ScalaPB 0.4.12 to depend on sbt-protobuf 0.4.0. I added to http://trueaccord.github.io/ScalaPB/sbt-settings.html instructions on how to use protoc-jar to avoid the dependency on protoc.

This is progress in the right direction, but the main issue of running ScalaPB outside SBT still remains.

thesamet added a commit that referenced this issue May 8, 2015
@ahjohannessen
Copy link
Contributor

This is great! 👍 Thank you very much for doing this :) Going to try it out now

@ahjohannessen
Copy link
Contributor

It works great 👍 I wondered why the following is printed out:

protoc-jar: protoc version: 261, detected platform: mac os x/x86_64
protoc-jar: executing: [/var/folders/y5/lswvltf14fx02nn9xhtv_65m0000gn/T/protoc4087409384165246742.exe, --plugin=protoc-gen-scala=...

It detects OS X correctly, but then it logs that it executes an .exe. That is a bit odd.

@ahjohannessen
Copy link
Contributor

@thesamet
Copy link
Contributor Author

There is now a supported way to run ScalaPB directly ftrom the command line, outside SBT. Look for spbc in http://trueaccord.github.io/ScalaPB/

thesamet added a commit that referenced this issue May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants