Benchmarks: run current version, parameters, profiling, structured results #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ak0rz
force-pushed
the
refactor_benchmarks
branch
from
a06d57d
to
20501ca
Compare
ak0rz
force-pushed
the
refactor_benchmarks
branch
from
20501ca
to
faf56a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I'm going to introduce numerous changes related to performance of scalapb, but I noticed that existing suite is outdated and using template-based codegen to build suites. Also, I noticed that present results are incomparable because there was no platform information in result structure.
Solution
First, I've made a small local plugin that handles all dependencies for benchmark projects, allowing using either scalapb built from current sources or downloaded from remote ivy repo.
Second, I performed refactoring of suites so they would be actual benchmark classes, possibly annotated with
@Stateand having@Paramparameters. Thus added ability to test repeated field with various number of elements.And lastly, I've made a custom JMH runner to be able to separate results for each benchmark in its own directory + put there profiling information too.
Pro-tip for review
Filter out all
.htmland.jsonfiles that was generated as a result of benchmark runs