Fix Runner Hang Problem #2090
Merged
Fix Runner Hang Problem #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g hang problem when it happens.
bvenners
reviewed
Jan 13, 2022
| @@ -1489,8 +1489,17 @@ object Runner { | |||
| // getDispatchReporter may complete abruptly with an exception, if there is an problem trying to load | |||
| // or instantiate a custom reporter class. | |||
| case ex: Throwable => { | |||
| System.err.println(Resources.bigProblemsMaybeCustomReporter) | |||
There was a problem hiding this comment.
I think this is an improvement, for sure, but this is another catch of Throwable. Should we be using NonFatal here also?
There was a problem hiding this comment.
@bvenners The Throwable was there before this PR, I think we did want to catch everything, as here we're going to fire RunAborted event to stop the run properly, if it is a fatal exception (like out of memory) that can cause the following code to not able to execute, I think it will be blowing up again here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fire RunAborted event when error in creating dispatch reporter, fixing hang problem when it happens.
This should fix the following issue:
#2069 (comment)