Type classes: use standard inheritance but hide it #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is certainly interesting :) |
|
Looking good! |
jbgi
force-pushed
the
instanceof-class
branch
from
555c303
to
0cb0e8f
Compare
through abstract type of InstanceOfModule
jbgi
force-pushed
the
instanceof-class
branch
from
0cb0e8f
to
f0fb9f5
Compare
edmundnoble
approved these changes
Feb 10, 2018
TomasMikula
approved these changes
Feb 10, 2018
|
Really nice |
|
I also really like this. Nice work! |
|
Benchmarks? |
|
@jbgi Nice work! Worth documenting in the Scalaz 8 design guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtyping is hiden from type system (and implicit resolution) through invariant abstract type (zero-cost wrapper) in
InstanceOfModule.See Original idea by @TomasMikula.
Ease of use of traditional encoding is thus preserved at the minor cost of wrapping instances construction in an
instanceOfmethod call.Remove all
Templateclasses. This also force type class instance to use inheritance (to preserve performance).