Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: purge old account support #3290

Merged
merged 13 commits into from
Jul 19, 2023
Merged

chore: purge old account support #3290

merged 13 commits into from
Jul 19, 2023

Conversation

remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@remyleone remyleone changed the title chore: add support for account/v3 chore: purge old account support Jul 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

Merging #3290 (c3a785f) into master (0dacbb8) will decrease coverage by 3.82%.
The diff coverage is 72.05%.

@@            Coverage Diff             @@
##           master    #3290      +/-   ##
==========================================
- Coverage   75.65%   71.83%   -3.82%     
==========================================
  Files         174      174              
  Lines       38386    38375      -11     
==========================================
- Hits        29041    27568    -1473     
- Misses       8290     9797    +1507     
+ Partials     1055     1010      -45     
Impacted Files Coverage Δ
internal/namespaces/account/v3/error.go 0.00% <ø> (ø)
internal/namespaces/account/v3/custom.go 72.46% <72.05%> (ø)

... and 3 files with indirect coverage changes

@Codelax Codelax added this pull request to the merge queue Jul 19, 2023
Merged via the queue into scaleway:master with commit 0927eda Jul 19, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants