Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance): support ipam ips on pnic creation #2660

Merged
merged 6 commits into from
Sep 27, 2024

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Jul 23, 2024

No description provided.

@yfodil yfodil added enhancement instance Instance issues, bugs and feature requests labels Jul 23, 2024
@yfodil yfodil self-assigned this Jul 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.04%. Comparing base (fe86049) to head (e95268e).
Report is 135 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2660      +/-   ##
==========================================
- Coverage   71.43%   71.04%   -0.40%     
==========================================
  Files         277      334      +57     
  Lines       35875    33506    -2369     
==========================================
- Hits        25628    23803    -1825     
+ Misses       8028     7392     -636     
- Partials     2219     2311      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax marked this pull request as ready for review September 27, 2024 08:30
@Codelax Codelax added this pull request to the merge queue Sep 27, 2024
Merged via the queue into scaleway:master with commit e0b97c3 Sep 27, 2024
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants