Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SelectInputV2): description in row should be baseline aligned #3858

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

DorianMaliszewski
Copy link
Member

Summary

Type

  • Bug

Summarise concisely:

What is expected?

Description of option in row mode should be baseline aligned

The following changes where made:

  1. Just add on the Stack alignItems="baseline"

Relevant logs and/or screenshots

Page Before After
url screenshot screenshot
url screenshot screenshot

@DorianMaliszewski DorianMaliszewski added the bug Something isn't working label Jun 7, 2024
@DorianMaliszewski DorianMaliszewski self-assigned this Jun 7, 2024
Copy link

changeset-bot bot commented Jun 7, 2024

🦋 Changeset detected

Latest commit: 8c50032

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (8c4e45a) to head (8c50032).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3858   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files         185      185           
  Lines        5921     5921           
  Branches     2631     2631           
=======================================
  Hits         5536     5536           
  Misses        385      385           
Files Coverage Δ
...ui/src/components/SelectInputV2/DropdownOption.tsx 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4e45a...8c50032. Read the comment docs.

@DorianMaliszewski DorianMaliszewski merged commit 36f2ef2 into main Jun 10, 2024
12 checks passed
@DorianMaliszewski DorianMaliszewski deleted the fix/selectinputV2-description-row branch June 10, 2024 08:02
@github-actions github-actions bot mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants