Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc review #123

Merged
merged 7 commits into from
Jun 13, 2018
Merged

Doc review #123

merged 7 commits into from
Jun 13, 2018

Conversation

wabernat
Copy link
Contributor

I made the docs say the same things more clearly with fewer words.

@ghost
Copy link

ghost commented Jun 10, 2018

There were the following issues with this Pull Request

  • Commit: 3991c6f
    • ✖ message may not be empty
      , - ✖ type may not be empty
  • Commit: 781ce41
    • ✖ message may not be empty
      , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

Copy link
Contributor

@ssalaues ssalaues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates just need some easy changes.

charts/README.md Outdated

```shell
$ helm install --name zenko --set ingress.enabled=true --set ingress.hosts[0]=zenko.local --set cloudserver-front.endpoint=zenko.local zenko
```

See `values.yml` for more options.
One noteworthy option is to enable integration with the [Orbit] management UI
(disabled by default) and set a custom Orbit API endpoint (for development
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not your fault, but the Orbit management is now enabled by default. Could we swap the wording around? So "option is to disable integration...(enabled by default)"

@@ -187,6 +188,7 @@ $ aws s3 --endpoint http://zenko ls s3://bucket1
```

### Clueso Search
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not your fault, but can we change this to simply "Metadata Search"

@@ -187,6 +188,7 @@ $ aws s3 --endpoint http://zenko ls s3://bucket1
```

### Clueso Search

Clueso search can be tested from within the S3-frontend container.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, change Clueso to "Metadata"

You can see the Spark Master UI at port 8080
Check out the Livy UI at port 8998
You can see the Spark Master UI at port 8080. Check out the Livy UI at port
8998.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this entire sentence as it is no longer relevant.

@ghost
Copy link

ghost commented Jun 13, 2018

There were the following issues with this Pull Request

  • Commit: 3991c6f
    • ✖ message may not be empty
      , - ✖ type may not be empty
  • Commit: 781ce41
    • ✖ message may not be empty
      , - ✖ type may not be empty
  • Commit: b48a711
    • ✖ message may not be empty
      , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

for swarm-production.
Helm chart README
charts/README.md revised to conform with Salim's comments
Added changes to top README.md & ISSUE_TEMPLATE.md
@ssalaues ssalaues merged commit a31f6f8 into master Jun 13, 2018
@ssalaues ssalaues deleted the DocReview branch June 13, 2018 22:32
@ssalaues ssalaues mentioned this pull request Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants