Encode enhancement #33
Conversation
| ~AsyncEncodeWorker() { | ||
| delete _orig_data; | ||
| } | ||
| ~AsyncEncodeWorker() {} |
There was a problem hiding this comment.
Don't we need to reset the persistent flag in the destructor?
There was a problem hiding this comment.
NanDisposePersistent() is apparently the way to go. That'll prevent leaks.
The persistent handle is dealt with in the destructor of AsyncWorker: https://github.com/nodejs/nan/blob/c212a7ca266e16efb2a8581b35f45ed72148b4f0/nan.h#L1484
There was a problem hiding this comment.
I don't really understand your question. Is it about _persistent_flag? If yes, we don't need to do that
|
One small nit, could we get rid of the flag itself ( |
|
👍 |
ghost
force-pushed
the
perf/not_copy_buffer
branch
from
22e04f1
to
aa0f862
Compare
For encoding a single object, it does not need to copy the object to make sure that it won't be deleted by garbage collector. In the case of encoding an array of buffers, a memory copy is still necessary.
|
Merging, as this is a straight improvement, thanks again! |
For encoding a single object, it does not need to copy the object to make sure
that it won't be deleted by garbage collector.
In the case of encoding an array of buffers, a memory copy is still necessary.