Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch Volume Creation from MetalK8s UI #2964

Closed
ChengYanJin opened this issue Dec 4, 2020 · 0 comments · Fixed by #2981
Closed

Batch Volume Creation from MetalK8s UI #2964

ChengYanJin opened this issue Dec 4, 2020 · 0 comments · Fixed by #2981
Assignees
@ChengYanJin
Labels
complexity:hard Something that may require up to a week to fix topic:operations Operations-related issues topic:storage Issues related to storage topic:ui UI-related issues

Comments

@ChengYanJin
Copy link
Contributor

ChengYanJin commented Dec 4, 2020 •
edited
Loading

Component: ui, volumes

Why this is needed:
We want to be able to batch create volume from UI.

What should be done:
image
image
Please check the HD from Sketch:

https://www.sketch.com/s/b7c9bece-ad22-40e6-b2b5-410645289650/a/qP32vd
https://www.sketch.com/s/b7c9bece-ad22-40e6-b2b5-410645289650/a/L5Vox5

Implementation proposal (strongly recommended):
When we choose SparseLoop Device, we can have the size field for each of the volume instead of path.

The number selection component is missing in core-ui. I would suggest first implement in MetalK8s and generalize it to core-ui.

For the moment, I only see Device Path require question mark next to it with the following text as tooltip.
A devicePath or a partition mount point. Example: /dev/sdb

We apply the same logic as the Scality Cloud does.
when selecting the multi-volume creation, by default we should have 1 volume to create.

We should dispatch the data in an array.

  [
    { name: "volume01'", devicePath: '/dev/sdb' },
    { name: "volume02'", devicePath: '/dev/sdc' },
  ];

Test plan:
We should implement the interaction test for the batch volume creation.
@ChengYanJin ChengYanJin added topic:storage Issues related to storage topic:ui UI-related issues complexity:medium Something that requires one or few days to fix labels Dec 4, 2020
@ChengYanJin ChengYanJin self-assigned this Dec 7, 2020
@ChengYanJin ChengYanJin added the topic:operations Operations-related issues label Dec 7, 2020
@ChengYanJin ChengYanJin added complexity:hard Something that may require up to a week to fix and removed complexity:medium Something that requires one or few days to fix labels Dec 8, 2020
ChengYanJin added a commit that referenced this issue Dec 14, 2020
@ChengYanJin
ui/styles: Remove the breadcrumb in Create New Volume page
3efa116 
We KILL breadcrumb!

Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 14, 2020
@ChengYanJin
ui/volumes: Set up the form of batch volume creation
372d5e3 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 14, 2020
@ChengYanJin
ui/utils: Add utility function to generate the linux drive name
3b5eac8 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 14, 2020
@ChengYanJin
ui/package: Upgrade the version of formik to v2
2e04d65 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 14, 2020
@ChengYanJin
ui/ducks/volumes: Change the payload of createVolume to an array
73e2266 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 14, 2020
@ChengYanJin
ui/utils: Add util function to format the data for batch volume
65abcea 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 14, 2020
@ChengYanJin
ui/volumes: Adapt the creationVolume container for batch volume creation
e75ff48 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 14, 2020
@ChengYanJin
ui/styles: Remove the breadcrumb in Create New Volume page
1a9bd2d 
We KILL breadcrumb!

Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 14, 2020
@ChengYanJin
ui/volumes: Set up the form of batch volume creation
0e802c6 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 14, 2020
@ChengYanJin
ui/utils: Add utility function to generate the linux drive name
6add626 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 14, 2020
@ChengYanJin
ui/package: Upgrade the version of formik to v2
6e907fa 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 14, 2020
@ChengYanJin
ui/ducks/volumes: Change the payload of createVolume to an array
2dba83e 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 14, 2020
@ChengYanJin
ui/utils: Add util function to format the data for batch volume
f5f6d38 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 14, 2020
@ChengYanJin
ui/volumes: Adapt the creationVolume container for batch volume creation
7c8dd1d 
Refs: #2964
@ChengYanJin ChengYanJin mentioned this issue Dec 14, 2020
Closed
ChengYanJin added a commit that referenced this issue Dec 14, 2020
@ChengYanJin
ui/styles: Remove the breadcrumb in Create New Volume page
160ea8b 
We KILL breadcrumb!

Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 14, 2020
@ChengYanJin
ui/volumes: Set up the form of batch volume creation
4be79a1 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 14, 2020
@ChengYanJin
ui/utils: Add utility function to generate the linux drive name
fc287bb 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 14, 2020
@ChengYanJin
ui/package: Upgrade the version of formik to v2
87a7cbb 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 14, 2020
@ChengYanJin
ui/ducks/volumes: Change the payload of createVolume to an array
c1386d8 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 14, 2020
@ChengYanJin
ui/utils: Add util function to format the data for batch volume
20d7b8d 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 18, 2020
@ChengYanJin
ui/styles: Fix the scroll bar issue by overflow:auto
1410b8a 
"overflow-y: scroll" protentially would display the scrollbar by default
even for non scrollable content, which casue the issue of we have the
scrollbar everywhere.

Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 18, 2020
@ChengYanJin
ui/volumes: Add unit test for formatVolumeCreationData function
f371b40 
Handle the single volume creation case in the utility function instead
of in the createVolume component so that the return of this function
is always an array.

For single volume, return an array with the origin volume.
For batch volume, return an array with the formatted volumes.

Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 18, 2020
@ChengYanJin
ui/volumes: Factorize the recommendField
c8d9379 
Correct the variable declaration too

Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 18, 2020
@ChengYanJin
ui/translation: Add missing translation for batch volume creation
1bc8143 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 18, 2020
@ChengYanJin
ui/styles: Remove the breadcrumb in Create New Volume page
15436b3 
We KILL breadcrumb!

Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 18, 2020
@ChengYanJin
ui/volumes: Set up the form of batch volume creation
79d964d 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 18, 2020
@ChengYanJin
ui/utils: Add utility function to generate the linux drive name
091781a 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 18, 2020
@ChengYanJin
ui/package: Upgrade the version of formik to v2
214b5d1 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 18, 2020
@ChengYanJin
ui/ducks/volumes: Change the payload of createVolume to an array
03e4f76 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 18, 2020
@ChengYanJin
ui/utils: Add util function to format the data for batch volume
a5cf6a1 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 18, 2020
@ChengYanJin
ui/volumes: Adapt the creationVolume container for batch volume creation
f53301d 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 18, 2020
@ChengYanJin
ui/styles: Fix the scroll bar issue by overflow:auto
6b4ee9e 
"overflow-y: scroll" protentially would display the scrollbar by default
even for non scrollable content, which casue the issue of we have the
scrollbar everywhere.

Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 18, 2020
@ChengYanJin
ui/volumes: Add unit test for formatVolumeCreationData function
317c0c8 
Handle the single volume creation case in the utility function instead
of in the createVolume component so that the return of this function
is always an array.

For single volume, return an array with the origin volume.
For batch volume, return an array with the formatted volumes.

Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 18, 2020
@ChengYanJin
ui/volumes: Factorize the recommendField
4ecfc4e 
Correct the variable declaration too

Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 18, 2020
@ChengYanJin
ui/translation: Add missing translation for batch volume creation
ac5c3ff 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 21, 2020
@ChengYanJin
ui/volumes: Fix the bug of input number doesn't sync with form
2083cee 
Ref: #2964
ChengYanJin added a commit that referenced this issue Dec 21, 2020
@ChengYanJin
ui/volumes: Fix the defaults path start from the input path
5cd9a87 
The recommend default device path should start from the global one

Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 21, 2020
@ChengYanJin
ui/volumes: Change the behaviour of the default name/path
ec0309f 
We only recommend the name/path for the empty field, means if the global
name/page get updated, the defaults won't change.

Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 21, 2020
@ChengYanJin
ui/volumes: Improve the name of the batch volume
1c36230 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 22, 2020
@ChengYanJin
ui/volumes: Improve the name of the batch volume
25026fb 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 22, 2020
@ChengYanJin
ui/volumes: Fix the default path bug when the index is over 53
769e0b4 
Set the max number of the input volume creation to 70, since it frozes
the UI when rendering the form.
We may even want to lower the max number depents on the use case.

Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 22, 2020
@ChengYanJin
ui/volumes: Set the max number of volume batch creation to 70
7002295 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 22, 2020
@ChengYanJin
ui/volumes: When re-check the box only update the untouched fields
4c3cbe3 
In order to keep the user customization, edit the global value
(name/path) should not affect the defaults pre-fill of the touched
field.

Unless the users uncheck the box of multi-volume creation and re-check
again, we only update the untouched field with the new global value.

Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 23, 2020
@ChengYanJin
ui/volumes: Improve the name of the batch volume
743ce67 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 23, 2020
@ChengYanJin
ui/volumes: Fix the default path bug when the index is over 53
ed0b77c 
Set the max number of the input volume creation to 70, since it frozes
the UI when rendering the form.
We may even want to lower the max number depents on the use case.

Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 23, 2020
@ChengYanJin
ui/volumes: Set the max number of volume batch creation to 70
1db10a8 
Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 23, 2020
@ChengYanJin
ui/volumes: When re-check the box only update the untouched fields
6622ce5 
In order to keep the user customization, edit the global value
(name/path) should not affect the defaults pre-fill of the touched
field.

Unless the users uncheck the box of multi-volume creation and re-check
again, we only update the untouched field with the new global value.

Refs: #2964
ChengYanJin added a commit that referenced this issue Dec 23, 2020
@ChengYanJin
ui/volumes: When re-check the box only update the untouched fields
5d584ae 
In order to keep the user customization, edit the global value
(name/path) should not affect the defaults pre-fill of the touched
field.

Unless the users uncheck the box of multi-volume creation and re-check
again, we only update the untouched field with the new global value.

Refs: #2964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChengYanJin ChengYanJin

Labels
complexity:hard Something that may require up to a week to fix topic:operations Operations-related issues topic:storage Issues related to storage topic:ui UI-related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[UI] Volume Batch Creation scality/metalk8s
1 participant
@ChengYanJin