Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetalK8s considers all ISO mounts under /srv/scality to be 'solutions' and fails otherwise #3128

Closed
NicolasT opened this issue Feb 17, 2021 · 0 comments · Fixed by #3182
Closed

MetalK8s considers all ISO mounts under /srv/scality to be 'solutions' and fails otherwise #3128

NicolasT opened this issue Feb 17, 2021 · 0 comments · Fixed by #3182
Assignees
@TeddyAndrieux
Labels
kind:bug Something isn't working topic:salt Everything related to SaltStack in our product topic:solutions Anything related to external "Solutions" integration with the platform

Comments

@NicolasT
Copy link
Contributor

Any mounted iso9660 FS under /srv/scality at a path that doesn't start with metalk8s- is considered to be a 'solution', and if it's not (no manifest.yaml etc), related code bails out.

Of course other things could be mounted at this path, so no real reason to reject these I guess?

See

metalk8s/salt/_modules/metalk8s_solutions.py

Line 159 in 5b3ca3a

def _is_solution_mount(mount_tuple):

@NicolasT NicolasT added kind:bug Something isn't working topic:solutions Anything related to external "Solutions" integration with the platform topic:salt Everything related to SaltStack in our product labels Feb 17, 2021
TeddyAndrieux added a commit that referenced this issue Mar 9, 2021
@TeddyAndrieux
salt: Do not consider all ISOs in /srv/scality as Solutions
2cf4e06 
Add more check about MetalK8s solutions ISOs, the ISOs mounted in
`/srv/scality` also need to have a `manifests.yaml` with some expected
keys like a good `kind` and `apiVersion`, otherwise the mounted ISO is
ignored and consider as a non-metalk8s mountpoint

Fixes: #3128
@TeddyAndrieux TeddyAndrieux mentioned this issue Mar 9, 2021
Merged
TeddyAndrieux added a commit that referenced this issue Mar 10, 2021
@TeddyAndrieux
salt: Do not consider all ISOs in /srv/scality as Solutions
7d6b332 
Add more check about MetalK8s solutions ISOs, the ISOs mounted in
`/srv/scality` also need to have a `manifests.yaml` with some expected
keys like a good `kind` and `apiVersion`, otherwise the mounted ISO is
ignored and consider as a non-metalk8s mountpoint

Fixes: #3128
TeddyAndrieux added a commit that referenced this issue Mar 10, 2021
@TeddyAndrieux
salt: Do not consider all ISOs in /srv/scality as Solutions
73dd33c 
Add more check about MetalK8s solutions ISOs, the ISOs mounted in
`/srv/scality` also need to have a `manifests.yaml` with some expected
keys like a good `kind` and `apiVersion`, otherwise the mounted ISO is
ignored and consider as a non-metalk8s mountpoint.
NOTE: Also remove the `_is_solution_mount` as a function is not needed
to do this since we iter on the list anyway

Fixes: #3128
@bert-e bert-e closed this as completed in a0e3b60 Mar 11, 2021
alexandre-allard added a commit that referenced this issue Mar 23, 2021
@alexandre-allard
packages: Add salt-minion in metalk8s sos plugin
595ab68 
Retrieve /etc/salt (excluding /etc/salt/pki)
and the journal logs from salt-minion service

Refs: #3128
alexandre-allard added a commit that referenced this issue Mar 25, 2021
@alexandre-allard
packages: Add salt-minion in metalk8s sos plugin
addd121 
Retrieve /etc/salt (excluding /etc/salt/pki)
and the journal logs from salt-minion service

Refs: #3128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TeddyAndrieux TeddyAndrieux

Labels
kind:bug Something isn't working topic:salt Everything related to SaltStack in our product topic:solutions Anything related to external "Solutions" integration with the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

salt: Do not consider all ISOs in /srv/scality as Solutions scality/metalk8s
2 participants
@NicolasT @TeddyAndrieux