Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use systemd cgroupdriver instead of cgroupfs in Kubelet #3366

Closed
TeddyAndrieux opened this issue May 7, 2021 · 2 comments · Fixed by #3377
Closed

Use systemd cgroupdriver instead of cgroupfs in Kubelet #3366

TeddyAndrieux opened this issue May 7, 2021 · 2 comments · Fixed by #3377
Assignees
@TeddyAndrieux
Labels
kind:debt Technical debt kind:dependencies Pull requests that update a dependency file

Comments

@TeddyAndrieux
Copy link
Collaborator

TeddyAndrieux commented May 7, 2021 •
edited
Loading

Component:

kubelet

Why this is needed:

To match recommendation from Kubernetes (kubeadm)

What should be done:

Change kubelet cgroupDriver to systemd (that, likely, implies some changes in contained, check https://kubernetes.io/docs/setup/production-environment/container-runtimes/#containerd-systemd)
@TeddyAndrieux TeddyAndrieux added kind:debt Technical debt kind:dependencies Pull requests that update a dependency file labels May 7, 2021
@TeddyAndrieux TeddyAndrieux self-assigned this May 7, 2021
@TeddyAndrieux TeddyAndrieux mentioned this issue May 7, 2021
Merged
@NicolasT
Copy link
Contributor

NicolasT commented May 7, 2021

We should research and/or test what the impact is of kubelet/containerd restart when this setting is changed. As in, if kubelet/containerd is using cgroupfs first, some Pods/containers are running, then we restart kubelet/containerd using the new driver, will they still properly 'find' the running containers, adopt them,...?

@TeddyAndrieux
Copy link
Collaborator Author

Sure it needs some more work/investigation/test

@TeddyAndrieux TeddyAndrieux mentioned this issue May 11, 2021
Merged
TeddyAndrieux added a commit that referenced this issue May 11, 2021
@TeddyAndrieux
salt: Use systemd cgroupdriver instead of cgroupfs
5ffaa75 
To match recommendation from Kubernetes/kubeadm, change the
`cgroupDriver` from Kubelet to `systemd` and update containerd config
file accordingly

Sees: https://kubernetes.io/docs/setup/production-environment/container-runtimes/#containerd-systemd

Fixes: #3366
@bert-e bert-e closed this as completed in d7a71a4 May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TeddyAndrieux TeddyAndrieux

Labels
kind:debt Technical debt kind:dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

salt: Use systemd cgroupdriver instead of cgroupfs scality/metalk8s
2 participants
@NicolasT @TeddyAndrieux