UI: provision volumes with labels #1979

carlito-scality · 2019-10-31T13:39:40Z

Component:UI

Context:

After bootstrap, a user must create Volumes to provide storage for Prometheus and AlertManager. We deploy a StorageClass for this, but the PersistentVolumeClaims for these services also use a labelSelector to pick the 'right' PersistentVolume.

Summary:

Acceptance criteria:

Closes: #1891 #1977

- Allow users to add labels to provision volumes with labels Ref: #1891

- Update font-size to have only 3 different sizes per page

bert-e · 2019-10-31T13:39:42Z

Hello carlito-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2019-10-31T13:39:46Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

slaperche-scality · 2019-11-04T09:15:42Z

ui/src/translations/fr.json

@@ -124,5 +123,10 @@
  "add_solution_to_environment": "Ajout d'une solution à l'environnement {environment}",
  "version_env": "Versions",
  "add_solution": "Ajout de la solution",
-  "advanced_monitoring": "Supervision Avancée"
+  "advanced_monitoring": "Supervision Avancée",


Supervision avancée (TBC, but I don't thing the French rules require to capitalize every word in a title, unlike the English ones)

Agreed, whatever the actual rules are, consistency with other messages should prevail.

Fixes: #1977

- Display labels list - Imrpove Breadcrumb by adding Volume label Ref: #1891

- update docs to help users to provision labels Ref: #1891

gdemonet

I'll let @ChengYanJin review the actual React code ;)

gdemonet · 2019-11-04T09:08:55Z

ui/src/translations/en.json

+  "advanced_monitoring": "Advanced Monitoring",
+  "add": "Add",
+  "labels": "Labels",
+  "enter_label_name": "Enter label name…",


Why the ellipsis?

gdemonet · 2019-11-04T10:57:23Z

ui/src/translations/fr.json

@@ -124,5 +123,10 @@
  "add_solution_to_environment": "Ajout d'une solution à l'environnement {environment}",
  "version_env": "Versions",
  "add_solution": "Ajout de la solution",
-  "advanced_monitoring": "Supervision Avancée"
+  "advanced_monitoring": "Supervision Avancée",


Agreed, whatever the actual rules are, consistency with other messages should prevail.

gdemonet · 2019-11-04T16:58:31Z

docs/operation/volume_management/volume_creation_deletion_gui.rst

+#. If you click the new volume listed in the **Volume list**,
+   you can get more information about this volume


Could be rephrased: If you click on any volume in the Volume list, you will see more information in the Volume detail view:

bert-e · 2019-11-04T17:00:39Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@gdemonet

Ref: #1891

ChengYanJin

LGTM!
There are two UX maybe we can improve later:

In CreateVolume page, we should check and warn users just in case they fill the label input but forget to click on Add button.
In VolumeInformation page the size of Label Table should change according to how many lines do we have.

carlito-scality · 2019-11-05T14:00:21Z

@bert-e approve

bert-e · 2019-11-05T14:00:27Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@gdemonet

The following options are set: approve

bert-e · 2019-11-05T14:04:48Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.4

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2019-11-05T15:59:33Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.4

The following branches have NOT changed:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3

Please check the status of the associated issue None.

Goodbye carlito-scality.

gdemonet · 2019-11-06T10:17:10Z

ui/src/ducks/app/volumes.js

@@ -212,6 +212,7 @@ export function* createVolumes({ payload }) {
    kind: 'Volume',
    metadata: {
      name: newVolume.name,
+      labels: newVolume.labels,


Oh no....... I missed this, labels were not supposed to go there, but in spec.template.metadata.labels :(

Ha indeed, otherwise we're labeling the volume itself and not the underlying PV.

carlito-scality added 3 commits October 31, 2019 11:27

UI: update core-ui to use new feature (above all Icon Button inverted)

3248d12

UI: CreateVolume - Add labels form

5a2c371

- Allow users to add labels to provision volumes with labels Ref: #1891

UI: Improve Banner/InformationList styles to be more consistent

fa0dbcd

- Update font-size to have only 3 different sizes per page

carlito-scality added moonshot topic:ui UI-related issues complexity:easy Something that requires less than a day to fix labels Oct 31, 2019

carlito-scality self-assigned this Oct 31, 2019

github-actions bot added the kind:dependencies Pull requests that update a dependency file label Oct 31, 2019

carlito-scality marked this pull request as ready for review October 31, 2019 15:46

carlito-scality requested a review from a team as a code owner October 31, 2019 15:46

slaperche-scality reviewed Nov 4, 2019

View reviewed changes

carlito-scality added 3 commits November 4, 2019 11:53

UI: VolumeInformation - Fix error when refreshing the page

6d2fdcc

Fixes: #1977

UI: VolumeInformation - Display labels list

c0a9e7c

- Display labels list - Imrpove Breadcrumb by adding Volume label Ref: #1891

Doc: update volume_creation_deletion_gui screenshots

7d1c28d

- update docs to help users to provision labels Ref: #1891

carlito-scality force-pushed the feature/ui-provision-volumes-with-labels branch from a9f69e5 to 7d1c28d Compare November 4, 2019 10:55

gdemonet suggested changes Nov 4, 2019

View reviewed changes

carlito-scality added 2 commits November 4, 2019 18:24

UI: improve translations

c8f7e67

Ref: #1891

Doc: improve documentation

aa2548c

Ref: #1891

carlito-scality force-pushed the feature/ui-provision-volumes-with-labels branch from b16143a to aa2548c Compare November 4, 2019 17:27

ChengYanJin approved these changes Nov 5, 2019

View reviewed changes

carlito-scality requested a review from gdemonet November 5, 2019 08:28

gdemonet approved these changes Nov 5, 2019

View reviewed changes

gdemonet mentioned this pull request Nov 5, 2019

UI: Add cluster status warning before provisioning the volume in Prometheus #1984

Merged

bert-e merged commit aa2548c into development/2.4 Nov 5, 2019

bert-e deleted the feature/ui-provision-volumes-with-labels branch November 5, 2019 15:59

gdemonet mentioned this pull request Nov 6, 2019

Merge 2.4.1 tag in development branch #2020

Merged

gdemonet reviewed Nov 6, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI: provision volumes with labels #1979

UI: provision volumes with labels #1979

carlito-scality commented Oct 31, 2019 •

edited

Loading

bert-e commented Oct 31, 2019

bert-e commented Oct 31, 2019

slaperche-scality Nov 4, 2019

gdemonet Nov 4, 2019

gdemonet left a comment

gdemonet Nov 4, 2019

gdemonet Nov 4, 2019

gdemonet Nov 4, 2019

bert-e commented Nov 4, 2019

ChengYanJin left a comment •

edited

Loading

carlito-scality commented Nov 5, 2019

bert-e commented Nov 5, 2019

bert-e commented Nov 5, 2019

bert-e commented Nov 5, 2019

gdemonet Nov 6, 2019

slaperche-scality Nov 6, 2019

		#. If you click the new volume listed in the Volume list,
		you can get more information about this volume

UI: provision volumes with labels #1979

UI: provision volumes with labels #1979

Conversation

carlito-scality commented Oct 31, 2019 • edited Loading

bert-e commented Oct 31, 2019

Hello carlito-scality,

bert-e commented Oct 31, 2019

Waiting for approval

slaperche-scality Nov 4, 2019

Choose a reason for hiding this comment

gdemonet Nov 4, 2019

Choose a reason for hiding this comment

gdemonet left a comment

Choose a reason for hiding this comment

gdemonet Nov 4, 2019

Choose a reason for hiding this comment

gdemonet Nov 4, 2019

Choose a reason for hiding this comment

gdemonet Nov 4, 2019

Choose a reason for hiding this comment

bert-e commented Nov 4, 2019

Waiting for approval

ChengYanJin left a comment • edited Loading

Choose a reason for hiding this comment

carlito-scality commented Nov 5, 2019

bert-e commented Nov 5, 2019

Waiting for approval

bert-e commented Nov 5, 2019

In the queue

bert-e commented Nov 5, 2019

gdemonet Nov 6, 2019

Choose a reason for hiding this comment

slaperche-scality Nov 6, 2019

Choose a reason for hiding this comment

carlito-scality commented Oct 31, 2019 •

edited

Loading

ChengYanJin left a comment •

edited

Loading