Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/2334 install yum utils #2343

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Bugfix/2334 install yum utils #2343

merged 2 commits into from
Mar 31, 2020

Conversation

alexandre-allard
Copy link
Contributor

Component: build, salt

Context: yum-utils package may not be present on the hosts where we deploy metalk8s, thus breaking the installation or expansion, because we never install it.

Summary: we now ship the yum-utils package in the ISO and install it at the beginning of repositories setup.

Acceptance criteria: be able to bootstrap a machine or do an expansion on a node without yum-utils installed prior to that.

Closes: #2334

@alexandre-allard
build: add yum-utils to redhat downloaded packages
80b745d 
download yum-utils RedHat package in the buildchain.
yum-utils is used to provide repoquery to be able
to lookup for packages and their dependencies and
enforce certain versions.

Refs: #2334
@alexandre-allard
salt: install yum-utils when configuring repos
060dfab 
we need to install yum-utils to provide repoquery
which is used in the macro pkg_installed() to be
able to lookup for packages and their dependencies
and enforce certain versions.

Refs: #2334
@alexandre-allard alexandre-allard requested a review from a team March 31, 2020 09:36
@bert-e
Copy link
Contributor

bert-e commented Mar 31, 2020

Hello alexandre-allard-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Mar 31, 2020

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Mar 31, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@alexandre-allard
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Mar 31, 2020

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.4

  • ✔️ development/2.5

  • ✔️ development/2.6

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Mar 31, 2020

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.4

  • ✔️ development/2.5

  • ✔️ development/2.6

The following branches have NOT changed:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3

Please check the status of the associated issue None.

Goodbye alexandre-allard-scality.

@bert-e bert-e merged commit 060dfab into development/2.4 Mar 31, 2020
@bert-e bert-e deleted the bugfix/2334-install-yum-utils branch March 31, 2020 13:21
@alexandre-allard alexandre-allard mentioned this pull request Mar 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdemonet gdemonet gdemonet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandre-allard @bert-e @gdemonet