Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump coredns from 1.3.1 to 1.6.5 #2582

Merged
merged 2 commits into from
Jul 7, 2020
Merged

build(deps): bump coredns from 1.3.1 to 1.6.5 #2582

merged 2 commits into from
Jul 7, 2020

Conversation

Ebaneck
Copy link
Contributor

@Ebaneck Ebaneck commented May 29, 2020

Component:

'deps', 'build'

Context:

See: #2572

Summary:

A followup of this PR: #2575

Acceptance criteria:

Closes: #2572

@Ebaneck Ebaneck requested a review from a team May 29, 2020 12:04
@bert-e
Copy link
Contributor

bert-e commented May 29, 2020

Hello ebaneck,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented May 29, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@Ebaneck
Copy link
Contributor Author

Ebaneck commented Jul 6, 2020

/status

@bert-e
Copy link
Contributor

bert-e commented Jul 6, 2020

Status

Status report is not available.

The following options are set: after_pull_request

@Ebaneck
deps: update coredns to version 1.6.5 on 2.6
e845c37 
Since we try to follow `kubeadm` standards and this branch
ships K8S 1.17, we should indeed update coredns to 1.6.5.
@Ebaneck
coredns: update the Corefile in coredns deployed.sls
141b9c7 
Since we are updating coredns from 1.6.2 to 1.6.5, we need
to update the Corefile to remove deprecated plugins.

Given that we follow kubeadm standards, the Corefile is
updated using the following specifification;

```
https://github.com/kubernetes/kubernetes/blob/release-1.17/cmd/kubeadm/app/phases/addons/dns/manifests.go#L306
```
@Ebaneck Ebaneck force-pushed the improvement/2572-update-coredns-to-1.6.5 branch from 03dae5d to 141b9c7 Compare July 7, 2020 10:25
@bert-e
Copy link
Contributor

bert-e commented Jul 7, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: after_pull_request

@Ebaneck
Copy link
Contributor Author

Ebaneck commented Jul 7, 2020

/status

@bert-e
Copy link
Contributor

bert-e commented Jul 7, 2020

Status

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jul 7, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@scality scality deleted a comment from bert-e Jul 7, 2020
@scality scality deleted a comment from bert-e Jul 7, 2020
@Ebaneck
Copy link
Contributor Author

Ebaneck commented Jul 7, 2020

/approve

@bert-e
Copy link
Contributor

bert-e commented Jul 7, 2020

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.6

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jul 7, 2020

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.6

The following branches have NOT changed:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5

Please check the status of the associated issue None.

Goodbye ebaneck.

@bert-e bert-e merged commit 666d816 into development/2.6 Jul 7, 2020
@bert-e bert-e deleted the improvement/2572-update-coredns-to-1.6.5 branch July 7, 2020 19:02
@Ebaneck Ebaneck mentioned this pull request Jul 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandre-allard alexandre-allard alexandre-allard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CoreDNS
3 participants
@Ebaneck @bert-e @alexandre-allard