Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packages: bump containerd to 1.4.3 #2956

Merged
merged 1 commit into from
Dec 2, 2020
Merged

packages: bump containerd to 1.4.3 #2956

merged 1 commit into from
Dec 2, 2020

Conversation

NicolasT
Copy link
Contributor

@NicolasT NicolasT commented Dec 1, 2020

This version includes a fix for CVE-2020-15257 as well as a bugfix which
could prevent issues with Pods remaining in Terminating state.

Fixes: #2955
Fixes: #2955
See: https://github.com/containerd/containerd/releases/tag/v1.4.3
See: GHSA-36xw-fx78-c5r4
See: containerd/containerd#4656

@NicolasT NicolasT requested a review from a team as a code owner December 1, 2020 19:16
@bert-e
Copy link
Contributor

bert-e commented Dec 1, 2020

Hello nicolast,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Dec 1, 2020

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@NicolasT
packages: bump containerd to 1.4.3
369edb6 
This version includes a fix for CVE-2020-15257 as well as a bugfix which
could prevent issues with Pods remaining in `Terminating` state.

Fixes: #2955
Fixes: #2955
See: https://github.com/containerd/containerd/releases/tag/v1.4.3
See: GHSA-36xw-fx78-c5r4
See: containerd/containerd#4656
See: #2956
@NicolasT NicolasT added kind:dependencies Pull requests that update a dependency file release:nice to have An issue planned for a release which may be moved out if required labels Dec 2, 2020
@NicolasT
Copy link
Contributor Author

NicolasT commented Dec 2, 2020

/approve

@bert-e
Copy link
Contributor

bert-e commented Dec 2, 2020

Build failed

The build for commit did not succeed in branch improvement/containerd-1.4.3.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Dec 2, 2020

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.7

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Dec 2, 2020

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.7

The following branches have NOT changed:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6

Please check the status of the associated issue None.

Goodbye nicolast.

@bert-e bert-e merged commit 369edb6 into development/2.7 Dec 2, 2020
@bert-e bert-e deleted the improvement/containerd-1.4.3 branch December 2, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandre-allard alexandre-allard alexandre-allard approved these changes

Assignees
No one assigned
Labels
kind:dependencies Pull requests that update a dependency file release:nice to have An issue planned for a release which may be moved out if required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade containerd to 1.4.3
3 participants
@NicolasT @bert-e @alexandre-allard