-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Certificates beacon no longer check apiserver URL #3053
Certificates beacon no longer check apiserver URL #3053
Conversation
Because we don't want to check this in certificate beacon, we make it optional.
Hello alexandre-allard-scality,My role is to assist you with the merge of this Status report is not available. |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option
|
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
This way, the function can be called by a user to check whether or not a kubeconfig needs to be regenerated using the following command: salt-call metalk8s_kubeconfig.validate \ /path/to/kubeconfig.conf
/approve |
Build failedThe build for commit did not succeed in branch w/2.8/bugfix/cert-beacon-no-apiserver-check. The following options are set: approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue None. Goodbye alexandre-allard-scality. |
Component:
salt
Context:
In kubeconfig beacon we check for the apiserver URL with a specific hardcoded port (6443) which is not working for some of the kubeconfigs (e.g. calico), thus triggering a certificate renewal every time the beacon run for this certificate (luckily the certificate is not renewed because there is too much days left).
Summary:
Make the apiserver check optional in the
metalk8s_kubeconfig.validate()
function and no longer check it in kubeconfig beacon.Acceptance criteria:
to be tested