Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificates beacon no longer check apiserver URL #3053

Merged
merged 3 commits into from
Jan 19, 2021

Conversation

alexandre-allard
Copy link
Contributor

Component:
salt

Context:
In kubeconfig beacon we check for the apiserver URL with a specific hardcoded port (6443) which is not working for some of the kubeconfigs (e.g. calico), thus triggering a certificate renewal every time the beacon run for this certificate (luckily the certificate is not renewed because there is too much days left).

Summary:
Make the apiserver check optional in the metalk8s_kubeconfig.validate() function and no longer check it in kubeconfig beacon.

Acceptance criteria:
to be tested

Because we don't want to check this in certificate
beacon, we make it optional.
@alexandre-allard alexandre-allard requested a review from a team as a code owner January 19, 2021 16:09
@bert-e
Copy link
Contributor

bert-e commented Jan 19, 2021

Hello alexandre-allard-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jan 19, 2021

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Jan 19, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

TeddyAndrieux
TeddyAndrieux previously approved these changes Jan 19, 2021
This way, the function can be called by a user
to check whether or not a kubeconfig needs to be
regenerated using the following command:

  salt-call metalk8s_kubeconfig.validate \
      /path/to/kubeconfig.conf
@alexandre-allard
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Jan 19, 2021

Build failed

The build for commit did not succeed in branch w/2.8/bugfix/cert-beacon-no-apiserver-check.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 19, 2021

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.7

  • ✔️ development/2.8

The following branches will NOT be impacted:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 19, 2021

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.7

  • ✔️ development/2.8

The following branches have NOT changed:

  • development/1.0
  • development/1.1
  • development/1.2
  • development/1.3
  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6

Please check the status of the associated issue None.

Goodbye alexandre-allard-scality.

@bert-e bert-e merged commit 191609e into development/2.7 Jan 19, 2021
@bert-e bert-e deleted the bugfix/cert-beacon-no-apiserver-check branch January 19, 2021 19:08
gdemonet added a commit that referenced this pull request Jan 22, 2021
gdemonet added a commit that referenced this pull request Feb 3, 2021
gdemonet added a commit that referenced this pull request Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants