salt: Add a check about conflicting services for MetalK8s

[TeddyAndrieux]

Component:

'pre-check', 'salt'

Context:

#3067

Summary:

If some service are started on the host where we want to deploy MetalK8s
the installation may not work properly (e.g.: firewalld)
Add a new function to check that those service are not started on the
host before deploying all the MetalK8s components.
NOTE: We do not automatically stop the service from the host since those
services may have been started for good reason, so just ask the user to
remove those packages

Acceptance criteria:

Bootstrap output with firewalld started

# /srv/scality/metalk8s-2.8.0-dev/bootstrap.sh 
> Determine the OS... done [0s]
> Checking that BootstrapConfiguration is present... done [0s]
> Pre-minion system tests... done [0s]
> Configure internal repositories... done [0s]
> Check mandatory packages presence... done [3s]
> Disabling Salt minion service... done [0s]
> Stopping Salt minion service... done [0s]
> Installing mandatory packages... done [10s]
> Configuring Salt minion to run in local mode... done [5s]
> Ensure archive is available... done [2s]
> Checking local node... fail [2s]

Failure while running step 'Checking local node'

Command: check_local_node

Output:

<< BEGIN >>
Error running 'metalk8s_checks.node': Node bootstrap: Service firewalld conflicts with MetalK8s installation, please stop and disable it.
<< END >>

This script will now exit

Expansion with firewalld started on the new node

# crictl exec -it 758110e823084 salt-run state.sls metalk8s.orchestrate.deploy_node saltenv=metalk8s-2.8.0-dev pillar="{'orchestrate': {'node_name': 'node-1'}}"
[...]
bootstrap_master:
----------
[...]
----------
          ID: Check node
    Function: metalk8s.saltutil_cmd
        Name: metalk8s_checks.node
      Result: False
     Comment: Running function metalk8s_checks.node failed on minions: node-1
     Started: 17:36:42.667642
    Duration: 9560.307 ms
     Changes:   
              ----------
              node-1:
                  ----------
                  retcode:
                      1
                  stderr:
                      Error running 'metalk8s_checks.node': Node node-1: Service firewalld conflicts with MetalK8s installation, please stop and disable it.
                  stdout:

Summary for bootstrap_master
------------
Succeeded: 1 (changed=2)
Failed:    1
------------
Total states run:     2
Total run time:  22.045 s

---

Fixes: #3067

[bert-e]

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• one peer

Peer approvals must include at least 1 approval from the following list:

• @jbertran

• @ChengYanJin

• @slaperche-scality

• @thomasdanan

• @lucieleonard

• @gdemonet

• @TeddyAndrieux

• @nootal

• @MonPote

• @tcarmet

• @sayf-eddine-scality

• @cmonfort

• @NicolasT

• @carlito-scality

• @alexandre-allard-scality

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• one peer

Peer approvals must include at least 1 approval from the following list:

• @thomasdanan

• @alexandre-allard-scality

• @JBWatenbergScality

• @gdemonet

• @lucieleonard

• @ChengYanJin

• @TeddyAndrieux

• @NicolasT

[TeddyAndrieux]

/approve

[bert-e]

Build failed

The build for commit did not succeed in branch bugfix/pre-check-firewalld.

The following options are set: approve

[bert-e]

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

• ✔️ development/2.8

The following branches will NOT be impacted:

• development/1.0
• development/1.1
• development/1.2
• development/1.3
• development/2.0
• development/2.1
• development/2.2
• development/2.3
• development/2.4
• development/2.5
• development/2.6
• development/2.7

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

• Any commit you add on the source branch will trigger a new cycle after the
  current queue is merged.
• Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ development/2.8

The following branches have NOT changed:

• development/1.0
• development/1.1
• development/1.2
• development/1.3
• development/2.0
• development/2.1
• development/2.2
• development/2.3
• development/2.4
• development/2.5
• development/2.6
• development/2.7

Please check the status of the associated issue None.

Goodbye teddyandrieux.