[UI] Drop the solution page and related test #3167

ChengYanJin · 2021-03-03T17:13:28Z

Component: ui, solutions

Context:
Since the solution UI is not really useful, we decided to completely drop this page as well as the codebase.

Summary:
Removed:

Solution page
Solution-related test, includes e2e solution in CI as well.
Sidebar solution entry
Remove all the related translations

Acceptance criteria:
No regression

closes: #3168

bert-e · 2021-03-03T17:13:30Z

Hello chengyanjin,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2021-03-03T17:13:37Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/remove-the-solution-test-and-drop-the-page into
development/2.8
w/2.9/improvement/remove-the-solution-test-and-drop-the-page will be merged into development/2.9

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e · 2021-03-03T17:13:38Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

JBWatenbergScality · 2021-03-03T17:17:11Z

Maybe we should mention this change in the changelog as well.

ChengYanJin · 2021-03-03T17:30:55Z

Maybe we should mention this change in the changelog as well.

Yes. Indeed, I will add a changelog entry.

JBWatenbergScality · 2021-03-04T09:09:58Z

ui/src/translations/fr.json

  "redirecting": "Redirection…",
-  "documentation": "Documentation",


Navbar tests are failling because I think this entry should not have been removed

I just realized it as well! Re-adding. Thanks for checking!

bert-e · 2021-03-04T09:31:02Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2021-03-04T14:37:48Z

Conflict

There is a conflict between your branch improvement/remove-the-solution-test-and-drop-the-page and the
destination branch development/2.8.

Please resolve the conflict on the feature branch (improvement/remove-the-solution-test-and-drop-the-page).

 $ git fetch
 $ git checkout origin/improvement/remove-the-solution-test-and-drop-the-page
 $ git merge origin/development/2.8
 $ # <intense conflict resolution>
 $ git commit
 $ git push origin HEAD:improvement/remove-the-solution-test-and-drop-the-page

eve/main.yml

bert-e · 2021-03-05T15:31:51Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2021-03-08T16:00:40Z

Conflict

There is a conflict between your branch improvement/remove-the-solution-test-and-drop-the-page and the
destination branch development/2.8.

Please resolve the conflict on the feature branch (improvement/remove-the-solution-test-and-drop-the-page).

 $ git fetch
 $ git checkout origin/improvement/remove-the-solution-test-and-drop-the-page
 $ git merge origin/development/2.8
 $ # <intense conflict resolution>
 $ git commit
 $ git push origin HEAD:improvement/remove-the-solution-test-and-drop-the-page

bert-e · 2021-03-09T10:03:51Z

History mismatch

Merge commit #829eedfba3d814adfeb730dc6b38d61e8721551d on the integration branch
w/2.9/improvement/remove-the-solution-test-and-drop-the-page is merging a branch which is neither the current
branch improvement/remove-the-solution-test-and-drop-the-page nor the development branch
development/2.9.

It is likely due to a rebase of the branch improvement/remove-the-solution-test-and-drop-the-page and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

ChengYanJin · 2021-03-09T10:04:12Z

/reset

bert-e · 2021-03-09T10:04:23Z

Reset complete

I have successfully deleted this pull request's integration branches.

bert-e · 2021-03-09T10:04:30Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge improvement/remove-the-solution-test-and-drop-the-page into
development/2.8
w/2.9/improvement/remove-the-solution-test-and-drop-the-page will be merged into development/2.9

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e · 2021-03-09T10:04:31Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

TeddyAndrieux

CI point of view, LGTM now 😄

ChengYanJin · 2021-03-09T14:49:34Z

/approve

bert-e · 2021-03-09T14:49:46Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.8
✔️ development/2.9

The following branches will NOT be impacted:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2021-03-09T14:49:53Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.8
✔️ development/2.9

The following branches have NOT changed:

development/1.0
development/1.1
development/1.2
development/1.3
development/2.0
development/2.1
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7

Please check the status of the associated issue None.

Goodbye chengyanjin.

ChengYanJin requested a review from a team as a code owner March 3, 2021 17:13

ChengYanJin requested review from gdemonet and JBWatenbergScality March 3, 2021 17:14

JBWatenbergScality previously approved these changes Mar 3, 2021

View reviewed changes

ChengYanJin dismissed JBWatenbergScality’s stale review via da6d746 March 3, 2021 17:49

ChengYanJin force-pushed the improvement/remove-the-solution-test-and-drop-the-page branch from da6d746 to c4c9448 Compare March 3, 2021 17:51

JBWatenbergScality previously approved these changes Mar 4, 2021

View reviewed changes

JBWatenbergScality reviewed Mar 4, 2021

View reviewed changes

ChengYanJin dismissed JBWatenbergScality’s stale review via 24d3555 March 4, 2021 09:30

ChengYanJin force-pushed the improvement/remove-the-solution-test-and-drop-the-page branch from c4c9448 to 24d3555 Compare March 4, 2021 09:30

scality deleted a comment from bert-e Mar 4, 2021

JBWatenbergScality previously approved these changes Mar 4, 2021

View reviewed changes

ChengYanJin linked an issue Mar 4, 2021 that may be closed by this pull request

Remove the Environment page from the MetalK8s UI #3168

Closed

ChengYanJin dismissed JBWatenbergScality’s stale review via e1828f5 March 4, 2021 18:11

ChengYanJin force-pushed the improvement/remove-the-solution-test-and-drop-the-page branch 2 times, most recently from e1828f5 to 9087f8f Compare March 5, 2021 09:25

TeddyAndrieux reviewed Mar 5, 2021

View reviewed changes

eve/main.yml Outdated Show resolved Hide resolved

ChengYanJin force-pushed the improvement/remove-the-solution-test-and-drop-the-page branch 2 times, most recently from da295b5 to a1001a5 Compare March 5, 2021 15:31

ChengYanJin added 3 commits March 9, 2021 10:59

ui/solutions: Remove the solution e2e test

d43159f

ui/solutions: Remove the access of solutions from sidebar and route

2ad9895

ui/package: Remove the scripts of solution e2e test

9e843fc

ChengYanJin force-pushed the improvement/remove-the-solution-test-and-drop-the-page branch from 9db782a to 88602f5 Compare March 9, 2021 10:03

ChengYanJin added 7 commits March 9, 2021 11:03

eve: Remove the command to execute the e2e solution test in CI

640cee8

ui/translations: Remove all the translations related to solution

72c6358

ui/solutions: Delete all the file/component/service related to solutions

e98c45c

ui/solutions: Remove the solution from saga, reducer

231ee4d

ui/solutions: Adapt the integration test cause by solution enter removed

cad3353

ui/solutions: Remove prepareEnv from Salt API

a2a55fb

changelog: Add the removal changelog of environment pagge

88602f5

scality deleted a comment from bert-e Mar 9, 2021

ChengYanJin requested a review from TeddyAndrieux March 9, 2021 10:06

TeddyAndrieux approved these changes Mar 9, 2021

View reviewed changes

JBWatenbergScality approved these changes Mar 9, 2021

View reviewed changes

bert-e merged commit 88602f5 into development/2.8 Mar 9, 2021

bert-e deleted the improvement/remove-the-solution-test-and-drop-the-page branch March 9, 2021 14:49

This was referenced Mar 10, 2021

Remove the Environment page from the MetalK8s UI #3168

Closed

Flakies and error in cypress Solutions tests #3109

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[UI] Drop the solution page and related test #3167

[UI] Drop the solution page and related test #3167

ChengYanJin commented Mar 3, 2021 •

edited

Loading

bert-e commented Mar 3, 2021

bert-e commented Mar 3, 2021

bert-e commented Mar 3, 2021

JBWatenbergScality commented Mar 3, 2021 •

edited

Loading

ChengYanJin commented Mar 3, 2021

JBWatenbergScality Mar 4, 2021

ChengYanJin Mar 4, 2021 •

edited

Loading

bert-e commented Mar 4, 2021

bert-e commented Mar 4, 2021

bert-e commented Mar 5, 2021

bert-e commented Mar 8, 2021

bert-e commented Mar 9, 2021

ChengYanJin commented Mar 9, 2021

bert-e commented Mar 9, 2021

bert-e commented Mar 9, 2021

bert-e commented Mar 9, 2021

TeddyAndrieux left a comment

ChengYanJin commented Mar 9, 2021

bert-e commented Mar 9, 2021

bert-e commented Mar 9, 2021

		"redirecting": "Redirection…",
		"documentation": "Documentation",

[UI] Drop the solution page and related test #3167

[UI] Drop the solution page and related test #3167

Conversation

ChengYanJin commented Mar 3, 2021 • edited Loading

bert-e commented Mar 3, 2021

Hello chengyanjin,

bert-e commented Mar 3, 2021

Integration data created

bert-e commented Mar 3, 2021

Waiting for approval

JBWatenbergScality commented Mar 3, 2021 • edited Loading

ChengYanJin commented Mar 3, 2021

JBWatenbergScality Mar 4, 2021

Choose a reason for hiding this comment

ChengYanJin Mar 4, 2021 • edited Loading

Choose a reason for hiding this comment

bert-e commented Mar 4, 2021

Waiting for approval

bert-e commented Mar 4, 2021

Conflict

bert-e commented Mar 5, 2021

Waiting for approval

bert-e commented Mar 8, 2021

Conflict

bert-e commented Mar 9, 2021

History mismatch

ChengYanJin commented Mar 9, 2021

bert-e commented Mar 9, 2021

Reset complete

bert-e commented Mar 9, 2021

Integration data created

bert-e commented Mar 9, 2021

Waiting for approval

TeddyAndrieux left a comment

Choose a reason for hiding this comment

ChengYanJin commented Mar 9, 2021

bert-e commented Mar 9, 2021

In the queue

bert-e commented Mar 9, 2021

ChengYanJin commented Mar 3, 2021 •

edited

Loading

JBWatenbergScality commented Mar 3, 2021 •

edited

Loading

ChengYanJin Mar 4, 2021 •

edited

Loading