Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI : 3256 Dashboard inventory panel #3420

Merged
merged 4 commits into from
Jul 20, 2021

Conversation

alexis-ld
Copy link
Contributor

@alexis-ld alexis-ld commented Jun 16, 2021

Component:
dashboard, inventory

Context: We want to add an inventory card to the dashboard page

Summary: The card displays the volume and node counts and their status

Screenshot 2021-06-16 at 16 21 40

**Please note that as of today to make it work you will need to use the last core-ui version not the one defined in package.json. Will update the version here when core-ui tabs issue will be fixed **

Acceptance criteria: #3256


Closes: #3256

@alexis-ld alexis-ld requested a review from a team as a code owner June 16, 2021 14:25
@bert-e
Copy link
Contributor

bert-e commented Jun 16, 2021

Hello alexis-ld,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jun 16, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

ui/src/components/DashboardInventory.js Outdated Show resolved Hide resolved
ui/src/components/DashboardInventory.test.js Outdated Show resolved Hide resolved
ui/src/components/DashboardInventory.test.js Outdated Show resolved Hide resolved
ui/src/components/DashboardInventory.test.js Outdated Show resolved Hide resolved
ui/src/components/DashboardInventory.js Show resolved Hide resolved
ui/src/components/DashboardInventory.test.js Outdated Show resolved Hide resolved
ui/src/components/DashboardInventory.test.js Show resolved Hide resolved
ui/src/containers/AlertProvider.js Show resolved Hide resolved
ui/src/components/DashboardInventory.test.js Show resolved Hide resolved
ui/src/components/DashboardInventory.js Show resolved Hide resolved
@bert-e
Copy link
Contributor

bert-e commented Jun 18, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@ChengYanJin ChengYanJin dismissed their stale review June 30, 2021 09:58

PR is good to go, wait for the new version of Tabs component in core-ui.

@bert-e
Copy link
Contributor

bert-e commented Jun 30, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

ui/public/config.json Outdated Show resolved Hide resolved
ui/src/components/DashboardInventory.js Outdated Show resolved Hide resolved
ui/cypress/fixtures/config.json Outdated Show resolved Hide resolved
ui/src/components/DashboardInventory.js Outdated Show resolved Hide resolved
ui/src/components/DashboardInventory.js Outdated Show resolved Hide resolved
ui/src/containers/DashboardPage.js Outdated Show resolved Hide resolved
ui/src/components/DashboardInventory.test.js Outdated Show resolved Hide resolved
ui/src/components/Navbar.js Outdated Show resolved Hide resolved
ui/src/containers/PlatformLibraryProvider.js Outdated Show resolved Hide resolved
ui/src/services/api.js Outdated Show resolved Hide resolved
@bert-e
Copy link
Contributor

bert-e commented Jul 15, 2021

Branches have diverged

This pull request's source branch improvement/3256-inventory-panel has diverged from
development/2.10 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the
following solutions:

  • Merge origin/development/2.10 into improvement/3256-inventory-panel
  • Rebase improvement/3256-inventory-panel onto origin/development/2.10

Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset command.

@alexis-ld alexis-ld force-pushed the improvement/3256-inventory-panel branch from 5261f73 to c783be9 Compare July 19, 2021 13:54
@bert-e
Copy link
Contributor

bert-e commented Jul 19, 2021

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Jul 19, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@alexis-ld alexis-ld changed the base branch from development/2.10 to development/2.11 July 19, 2021 13:55
ui/src/components/DashboardInventory.js Outdated Show resolved Hide resolved
ui/src/components/DashboardInventory.js Outdated Show resolved Hide resolved
ui/src/components/DashboardInventory.test.js Outdated Show resolved Hide resolved
@ChengYanJin ChengYanJin self-assigned this Jul 20, 2021
@alexis-ld alexis-ld force-pushed the improvement/3256-inventory-panel branch from 9fe0a65 to f2bf890 Compare July 20, 2021 12:24
Copy link
Contributor

@ChengYanJin ChengYanJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bert-e
Copy link
Contributor

bert-e commented Jul 20, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@alexis-ld
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Jul 20, 2021

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.11

The following branches will NOT be impacted:

  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jul 20, 2021

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.11

The following branches have NOT changed:

  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye alexis-ld.

@bert-e bert-e merged commit 60d193b into development/2.11 Jul 20, 2021
@bert-e bert-e deleted the improvement/3256-inventory-panel branch July 20, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metalk8s UI Overview page inventory panel
3 participants