Improvement: 3093 Dashboard Services panel #3465
Conversation
This allows the use of react-router components insed tested components Refs: #3093
Hello alexis-ld,My role is to assist you with the merge of this Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list:
|
| const filtered = alerts.filter((item) => item && item.startsAt); | ||
| // Sort to make sure we have oldest alert first | ||
| filtered.sort((a, b) => new Date(a.startsAt) - new Date(b.startsAt)); |
There was a problem hiding this comment.
it's good thinking, however, I don't think it's necessary ;)
In theory, at the current time, the same alert should not be triggered more than once.
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list:
The following reviewers are expecting changes from the author, or must review again: |
…and core-ui's components Leverage core-ui's StatusText instead of local implementation Use formatDateToMid1 instead of custom Date formatting Refs: #3093
alexis-ld
force-pushed
the
improvement/3093-services-panel
branch
from
96a1546
to
b5a13c0
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list:
|
|
/bypass_author_approval |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: bypass_author_approval |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue None. Goodbye alexis-ld. |
Component: dashboard
Context: #3093
Summary: Adds a Services panel to the dashboard
Screen.Recording.2021-07-29.at.14.01.59.mov
Closes: #3093