Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-write Kubernetes Salt module to use DynamicClient #3510

Merged
merged 2 commits into from
Aug 31, 2021
Merged

Re-write Kubernetes Salt module to use DynamicClient #3510

merged 2 commits into from
Aug 31, 2021

Conversation

TeddyAndrieux
Copy link
Collaborator

Component:

'salt', 'tests'

Context:

#3487

Summary:

  • Rewrite salt metalk8s_kubernetes execution module to use DynamicClient
  • Remove salt kubernetes utils module as it's no longer needed
  • Update e2e tests to use DynamicClient as well

Fixes: #3487

@TeddyAndrieux TeddyAndrieux requested a review from a team August 26, 2021 16:46
@bert-e
Copy link
Contributor

bert-e commented Aug 26, 2021

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Aug 26, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@TeddyAndrieux TeddyAndrieux force-pushed the improvement/rewrite-kubernetes-salt-module branch from f34a899 to 9d04287 Compare August 26, 2021 18:54
@bert-e
Copy link
Contributor

bert-e commented Aug 26, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@TeddyAndrieux
salt: Rework kubernetes salt module to use DynamicClient
884b6fc 
In order to be more flexible and not be tied to a `python-kubernetes`
version compatible with the Kubernetes version embedded in MetalK8s we
rely on `DynamicClient` in our salt Kubernetes execution module

Fixes: #3487
@TeddyAndrieux TeddyAndrieux force-pushed the improvement/rewrite-kubernetes-salt-module branch 3 times, most recently from 387924c to c7af864 Compare August 27, 2021 08:11
@TeddyAndrieux
tests: Rework pytest to use DynamicClient
f19095b 
Since we no longer use python-kubernetes models in the product let's
also move to `DynamicClient` in the tests.

NOTE: Tests can likely be rewrited a bit more but this commit just move
to `DynamicClient`
@TeddyAndrieux TeddyAndrieux force-pushed the improvement/rewrite-kubernetes-salt-module branch from c7af864 to f19095b Compare August 27, 2021 08:50
@TeddyAndrieux TeddyAndrieux marked this pull request as ready for review August 27, 2021 09:10
@gdemonet
Copy link
Contributor

Thanks for the heavy lifting 💪

@TeddyAndrieux
Copy link
Collaborator Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Aug 31, 2021

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.11

The following branches will NOT be impacted:

  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Aug 31, 2021

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.11

The following branches have NOT changed:

  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye teddyandrieux.

@bert-e bert-e merged commit f19095b into development/2.11 Aug 31, 2021
@bert-e bert-e deleted the improvement/rewrite-kubernetes-salt-module branch August 31, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdemonet gdemonet gdemonet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump Kubernetes to 1.22.X impossible with current python-kubernetes version
3 participants
@TeddyAndrieux @bert-e @gdemonet