Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/volume size display #3650

Closed
wants to merge 2 commits into from
Closed

Bugfix/volume size display #3650

wants to merge 2 commits into from

Conversation

gaudiauj
Copy link
Contributor

Component:

Volumes Table, and overview component

Context:
fix those bug :

image (9)
image (10)

@gaudiauj
bugfix: fix size display
942f36a 
we were adding a B at the end of the size display, however sometimes the B was already here. fixed the function to add a B only when needed
@gaudiauj
bugfix: don't display the usage percentage if the percentage is undef…
9ff1120 
…ined.
@gaudiauj gaudiauj self-assigned this Dec 30, 2021
@gaudiauj gaudiauj requested a review from a team as a code owner December 30, 2021 14:45
@bert-e
Copy link
Contributor

bert-e commented Dec 30, 2021

Hello gaudiauj,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Dec 30, 2021

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Dec 30, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@gaudiauj
Copy link
Contributor Author

should go on development/2.10 closing in favor of : #3651

@gaudiauj gaudiauj closed this Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChengYanJin ChengYanJin Awaiting requested review from ChengYanJin

@JBWatenbergScality JBWatenbergScality Awaiting requested review from JBWatenbergScality

Assignees

@gaudiauj gaudiauj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaudiauj @bert-e