Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

salt: Remove the Control Plane Ingress controller PDB in pre-upgrade #3724

Merged
merged 2 commits into from
Mar 16, 2022
Merged

salt: Remove the Control Plane Ingress controller PDB in pre-upgrade #3724

merged 2 commits into from
Mar 16, 2022

Conversation

TeddyAndrieux
Copy link
Collaborator

@TeddyAndrieux TeddyAndrieux commented Mar 15, 2022 •
edited
Loading

The control plane Ingress might be not working during the upgrade
but since it's only for a specific upgrade path and transient since it's
fixed after the upgrade we only remove the PodDisruptionBugdget so that
the upgrade complete

NOTE: The workaround has been removed in 123.0 integration branch

@TeddyAndrieux
salt: Remove the Control Plane Ingress controller PDB in pre-upgrade
047cc11 
NOTE: The control plane Ingress may be not working during the upgrade
but since it's only for a specific upgrade path and transient since it's
fixed after the upgrade we only remove the PodDisruptionBugdget so that
the upgrade complete
@TeddyAndrieux TeddyAndrieux requested a review from a team as a code owner March 15, 2022 13:13
@bert-e
Copy link
Contributor

bert-e commented Mar 15, 2022

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e

This comment was marked as duplicate.

Sign in to view
@bert-e

This comment was marked as duplicate.

Sign in to view
@TeddyAndrieux
packages: Disable repo_gpgcheck for Kubernetes repository
54410f2 
Right now we cannot use the Kubernetes with repo_gpgcheck enabled likely
due to a bug.
Since we only use this repository at build time and we still enable the
gpgcheck for package it self we can safely disable repo_gpgcheck, it
will avoid this kind of issue in the future (NOTE: We already faced the
exact same issue one year ago)
@bert-e

This comment was marked as resolved.

Sign in to view
@bert-e

This comment was marked as resolved.

Sign in to view
@bert-e

This comment was marked as resolved.

Sign in to view
@TeddyAndrieux
Copy link
Collaborator Author

/force_reset

@bert-e
Copy link
Contributor

bert-e commented Mar 15, 2022

Reset complete

I have successfully deleted this pull request's integration branches.

@bert-e
Copy link
Contributor

bert-e commented Mar 15, 2022

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Mar 15, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@TeddyAndrieux
Copy link
Collaborator Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Mar 16, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.11

  • ✔️ development/123.0

The following branches will NOT be impacted:

  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Mar 16, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.11

  • ✔️ development/123.0

The following branches have NOT changed:

  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye teddyandrieux.

@bert-e bert-e merged commit 54410f2 into development/2.11 Mar 16, 2022
@bert-e bert-e deleted the bugfix/fix-cp-ingress-upgrade branch March 16, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdemonet gdemonet gdemonet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TeddyAndrieux @bert-e @gdemonet