Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(test): unit test to run on push commit instead of commit #624

Merged
merged 2 commits into from
May 27, 2024

Conversation

theJohnnyMe
Copy link
Contributor

Describe pull-request

Moving running test from pre-commit to pre-push

Issue Linking:

  • No issue: Making a better world for developers.

How to test

  1. Run this branch on your local, and create another branch out of it.
  2. Trying changing anything.
  3. Try to commit, it should be instant.
  4. Try to push that branch as remote or push your changes, it should take a bit more as unit tests are running.

Checklist before submission

  • I have added unit tests for my changes (if applicable)
  • All existing tests pass
  • I have updated the documentation (if applicable)

Suggested test steps

  • Browser testing (Chrome, Safari, Firefox)
  • Keyboard operability
  • Interactive elements have labels.
  • Storybook controls
  • Design/controls/props is aligned with other components
  • Dark/light mode and variants
  • Input fields – values should be displayed properly
  • Events

Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-624.d3fazya28914g3.amplifyapp.com

Copy link
Contributor

@timrombergjakobsson timrombergjakobsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@nathalielindqvist nathalielindqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@theJohnnyMe theJohnnyMe merged commit 95b09c3 into develop May 27, 2024
2 checks passed
@theJohnnyMe theJohnnyMe deleted the fix/precommit-hook-test branch May 27, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants