We are a Shoes reimplementation #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! For the same reason I would recommend we remove the scarpe require. Shoes doesn't need it done explicitly, nor does our runner script. |
|
I'll resolve conflicts and merge after lunch. since I changed all the examples haha |
|
got rid of requires |
gajewsky
approved these changes
Feb 9, 2023
CalvinWalzel
approved these changes
Feb 9, 2023
Signed-off-by: Nick Schwaderer <nick.schwaderer@shopify.com>
Signed-off-by: Nick Schwaderer <nick.schwaderer@shopify.com>
Signed-off-by: Nick Schwaderer <nick.schwaderer@shopify.com>
Schwad
force-pushed
the
schwad_might_i_recommend_shoes
branch
from
338461a
to
078785b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@noahgibbs raised the point at checkin yesterday that we are a Shoes reimplementation. We are targeting compatibility with existing Shoes apps. So we should probably calling
Shoesfor our apps.To me, this sort of makes sense. TruffleRuby, for example, doesn't require any changes to your Ruby in order to be able to run!
Signed-off-by: Nick Schwaderer nick.schwaderer@shopify.com