feat: Add more granular spacing options #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christhesoul
reviewed
Feb 9, 2023
| when Array | ||
| DIRECTIONS.zip(values).to_h.each do |direction, value| | ||
| styles["#{attribute}-#{direction}"] = Dimensions.length(value) | ||
| end |
There was a problem hiding this comment.
Nit: What happens here if somebody sends in an array of three elements? Should we compact after the to_h?
There was a problem hiding this comment.
Then only margin-left, margin-right, and margin-top will be set. We could compact here but the compact! handles all cases so probably not needed.
There was a problem hiding this comment.
I benchmarked it real quick and the difference is fairly minor but a complex enough layout (100,000+ stacks) could see a speed boot (~100-200 ms) from compacting post to_h so I'm going to make the change. Good call!
a complex enough layout (100,000+ stacks) could see a speed boot (~100-200 ms) from compacting post to_h
noahgibbs
approved these changes
Feb 10, 2023
Schwad
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds multiple ways to set margin and/or padding on stacks and flows:
single value:
array of values:
hash with values:
keywords: