V.1.search.add sorting #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Issue rendering updated selection to webpage
Issue to fix: When sorting by 'date created', does not display all actions dating from the beginning, displays only a couple months back
Issue: Still unable to apply sort to all actions. Sort applies to rows of actions per page (i.e. 10 per page) instead of all at once
Issue: Only updates the rows displayed on the page at a time. Not the entire length of rows
randyhoulahan
force-pushed
the
v.1.search.add-sorting
branch
3 times, most recently
from
f8e2ff6
to
1eeb749
Compare
randyhoulahan
requested changes
Sep 15, 2021
| } | ||
|
|
||
| function updateSortSearchQuery(){ | ||
| resetSearchParams() |
There was a problem hiding this comment.
If someone chose a filter first then wanted to sort, would resetSearchParams remove it?
|
|
||
|
|
||
| return s | ||
| return sortPropertyName? { [`meta.${sortPropertyName}`]: -1 }: { 'meta.modifiedOn': -1, 'meta.createdOn': -1 } |
There was a problem hiding this comment.
@hmalik129 please review this line and if you have any questions on what is happening let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In progress Implementation.
Issue: Unable to get the query send properly for "s".
The problem is that to create the path, I am not sure if I am to add the sorting path in "filter-to-schema-property-map.js" & "index.js" and retrieve path from there OR code the pathway within the "query.js" which i currently have done but am unable to make it work.