Unrolled if-else-end , etc. statements, cleaned up whitespace #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unrolled one-line if-else-end statements, else statements with commands on the same line, etc. Removed trailing commas and semicolons where not needed, eg. end;. Reindented and removed trailing whitespace from lines.
|
I hate to be the party pooper. This commit has thousands of changes and we cannot check them all. While the person who originally programmed that function might not have had the best programing style, and that some of the changes present in this pull request might be relevant, I feel (1) we should respect the person who programmed the function (2) accepting the changes blindly could lead to potential bugs (because there are so many and there could be a typo that could only become apparent years later). |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unrolled one-line if-else-end statements, else statements with commands on the same line, etc.
Removed trailing commas and semicolons where not needed, eg. end;.
Reindented and removed trailing whitespace from lines.