Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cutting releases #322

Closed
kephale opened this issue Nov 29, 2020 · 5 comments
Closed

Cutting releases #322

kephale opened this issue Nov 29, 2020 · 5 comments

Comments

@kephale
Copy link
Member

kephale commented Nov 29, 2020

this hash of scijava-scripts works for cutting releases: eb4048825e47c0e757bd6fd2e294bd31b4a933df

@imagejan
Copy link
Contributor

imagejan commented Dec 3, 2020

Linking here for convenience:
scijava/scijava-scripts@eb40488

@kephale
Copy link
Member Author

kephale commented Dec 3, 2020

Thanks @imagejan. I have to say I ended up quite frustrated by all of the changes in scijava scripts since our last release. They drastically changed my workflow for cutting releases (e.g. by enforcing a lot of requirements). It turned out that when I was time limited to make an I2K release, that trying to handle all of the scijava-script requirements made it impossible to cut a quick release. For that reason I wanted to at least track the last version of scijava-scripts that was used to make sure that doesn't happen again.

@imagejan
Copy link
Contributor

imagejan commented Dec 3, 2020

thanks for clarifying, @kephale, that makes sense. In general, I think @ctrueden implemented the strict requirements for a good reason (e.g. make sure that you have no local untracked changes when trying the local build before proceeding, etc.), but if you think some of them are unnecessary, or in the way of quick progress, I think it's worth discussing these in an issue on scijava-scripts, no?

@ctrueden
Copy link
Member

ctrueden commented Dec 8, 2020

trying to handle all of the scijava-script requirements made it impossible to cut a quick release

@kephale I am sorry you experienced frustration at the hands of release-version.sh. The new requirements were intended help avoid mistakes, not prevent releases. Which requirement(s) specifically made it "impossible" for you?

Edit: Oh, I see now the related issue scijava/scijava-scripts#37. I will read that over, thanks.

@kephale
Copy link
Member Author

kephale commented Dec 8, 2020

@ctrueden License headers (partially because there was code included from other people's code bases: intellij and trove) and the uncommited changes for git (which IIRC got stuck in an infinite loop where git stash didn't fix anything and I couldn't find any changes). I do admit I was under time pressure because this was happening hours before our I2K tutorial, so things were getting very hasty. It was also compounded by my frustration with the JDK version enforcement in maven, which Saalfeld recently helped resolve. But all of that, which really had nothing to do with actual code, I have to admit, I was blowing my lid.

edit
By which I mean, there were more bugs to be fixed and I could not fix them because I lost the rest of the hours dealing with tooling issues (plus the imagej-mesh issue we had that you saved us from minutes before the tutorial started).

@kephale kephale closed this as completed Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants