TwoFactorFormListener: check if request has a session #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There could be situations where no session is given, in that case $this->tokenStorage->getToken() will throw an exception.
|
Oke, would you please add a test case for this scenario? |
|
@scheb there's no existing test for |
|
Ohhh, well, there should be one. I should definitely add that 🙈 So forget what I said, nothing for you, except you'd feel fancy to add it. |
|
@scheb alright, thanks - then I'll leave the PR as it is for now 😊 |
|
Forgot to approve the build. So now it's throwing out some formatting issues. Would you please run php-cs-fixer? That should do it. |
|
@scheb fixed, but needs again approval 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There could be situations where no session is given, in that case
$this->tokenStorage->getToken()will throw an exception.I think it would be better to just skip the handler in that case.