Removed sebastian/finder-facade and added replacement #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scheb
requested changes
Nov 13, 2021
added 7 commits
November 15, 2021 16:25
scheb
approved these changes
Nov 16, 2021
|
Released as v1.5.0. Thank you so much for contributing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes sebastian/finder-facade and adds a replacement class so the calling class is the same. This is needed as part of the upgrade to 8.0.
Closes #19
nikic/php-parser made a change in the 4.13 release that's breaking the psalm tests. I locked it to 4.12.0.