scx_rusty: Remove skip_while in find_first_candidate #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but could you please rebase onto |
Followed commit 1c3b563, move the checking of task.migrated.get() into the vector filter. In this way, we can remove the skip_while() call in find_first_candidate(). Signed-off-by: I Hsin Cheng <richard120310@gmail.com>
Remove unused variable "has_preferred_dom". Signed-off-by: I Hsin Cheng <richard120310@gmail.com>
|
I've rebased it and found an unused variable in recent commits. I removed it and contain it in this PR, hope it doesn't harm. |
hodgesds
reviewed
Jul 18, 2024
| @@ -1507,7 +1507,6 @@ static u32 task_pick_domain(struct task_ctx *taskc, struct task_struct *p, | |||
| { | |||
| s32 cpu = bpf_get_smp_processor_id(); | |||
| u32 first_dom = NO_DOM_FOUND, dom, preferred_dom = NO_DOM_FOUND; | |||
| int has_preferred_dom; | |||
There was a problem hiding this comment.
Whoops, I left that in... nice catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Followed commit 1c3b563, move the checking of task.migrated.get() into the vector filter. In this way, we can remove the skip_while() call in find_first_candidate().