Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade bindgen to 0.68 #50

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Conversation

jordalgo
Copy link
Contributor

This is so we can package scx_utils into fedora without having to upgrade rust-bindgen
(https://bodhi.fedoraproject.org/updates/FEDORA-2023-18e7f124e1).

To make this happen we need to stop using the CargoCallbacks::new constructor which was added in 0.69. Old way seems legit according to the docs:
https://rust-lang.github.io/rust-bindgen/non-system-libraries.html

@jordalgo
Copy link
Contributor Author

Now we get a warning if we build with 0.69:

[29/32] Generating rust/scx_utils/scx_utils with a custom command (wrapped by meson to set env)
warning: use of deprecated constant `bindgen::CargoCallbacks`: Use `CargoCallbacks::new()` instead. Please, check the documentation for further information.
  --> src/bpf_builder.rs:509:48
   |
509 |             .parse_callbacks(Box::new(bindgen::CargoCallbacks))
   |                                                ^^^^^^^^^^^^^^
   |
   = note: `#[warn(deprecated)]` on by default

This is so we can package scx_utils into fedora without having
to upgrade rust-bindgen
(https://bodhi.fedoraproject.org/updates/FEDORA-2023-18e7f124e1).

To make this happen we need to stop using the `CargoCallbacks::new`
constructor which was added in 0.69. Old way seems legit according
to the docs:
https://rust-lang.github.io/rust-bindgen/non-system-libraries.html
@htejun htejun merged commit 1d868db into sched-ext:main Dec 28, 2023
1 check passed
htejun added a commit that referenced this pull request Dec 28, 2023
…deprecation warning

This is a followup to #50. See the
comment in BpfBuilder::bindgen_bpf_intf() for details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants