ci: Fix veristat pull request workflow #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the [failure](https://github.com/sched-ext/scx/actions/runs/10389671253), which needs to have an action defined. Signed-off-by: Daniel Hodges <hodges.daniel.scott@gmail.com>
hodgesds
commented
Aug 19, 2024
| @@ -59,6 +59,9 @@ jobs: | |||
| # Generate kernel headers | |||
| - run: cd linux && make headers | |||
|
|
|||
| - run: wget https://github.com/libbpf/veristat/releases/download/v0.3.2/veristat-v0.3.2-amd64.tar.gz | |||
There was a problem hiding this comment.
@arighi I'm not sure if veristat is packaged for ubuntu so I'm just downloading it here directly.
hodgesds
commented
Aug 19, 2024
| @@ -21,7 +21,7 @@ if [ -n "${SCHED}" ]; then | |||
| if [ -n "${KERNEL}" ]; then | |||
| timeout --preserve-status ${GUEST_TIMEOUT} \ | |||
| vng --force-9p -v -r ${KERNEL} -- \ | |||
| veristat ${BPF_PATH} | |||
| ./veristat ${BPF_PATH} | |||
There was a problem hiding this comment.
This is to use the downloaded veristat inside vng. I think this will work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the failure which needs to have an action defined.