scx_stats: Drop sched-ext namespace #573

sirlucjan · 2024-08-27T16:08:02Z

Since scx_stats has been implemented, namespace is already redundant.

Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>

arighi

Left a couple of comments (feel free to ignore), but overall looks good!

arighi · 2024-08-27T19:06:31Z

services/README.md


 ```
-journalctl --namespace=sched-ext --disk-usage
+scx_SCHEDNAME --monitor X


Maybe change to --monitor SEC here to make it more clear that the argument defines the interval (in seconds) to print the output.

arighi · 2024-08-27T19:09:39Z

services/README.md

 ```

+X - for example 1 - this will print the output every second
+
+


And maybe add a real example, like:

scx_bpfland --monitor 0.5

To make it even more clear and to show that it also supports numbers with decimals.

I agree adding real examples would be nicer here.
For example, in case of LAVD, its monitoring option is a bit different from the others.

/// Run in monitoring mode. Show the specified number of scheduling /// samples every second. #[clap(long)] monitor_sched_samples: Option<u64>,

Could you take a look, please?

sirlucjan · 2024-08-27T19:24:08Z

@arighi I don't like to ignore wise advice. Is it better now?

sirlucjan · 2024-08-29T14:49:31Z

@arighi @multics69

Maybe we should move the log information to a separate README or write information about it in the main one?

arighi · 2024-08-29T14:53:45Z

Hm... maybe the monitor info should go in the main README, since they're affecting everyone and not only those that are running the schedulers via systemd.

sirlucjan · 2024-08-29T14:58:53Z

Let me know if the corrected examples are good and I will send the revisions to README.

Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>

ptr1337 · 2024-08-30T17:05:27Z

README.md

+- scx_rustland
+
+```
+❯ run0 scx_rustland --monitor 5


Why using here run0?

ptr1337 · 2024-08-30T17:06:22Z

README.md

+for example 0.5 - this will print the output every half a second
+
+```
+scx_bpfland --monitor 0.5


Personally would remove this part with the "for example 0.5". This just makes the README bigger with not much value

I think such an example can stay to show exactly what it is about, but if more people think the same, I will remove it.

ptr1337 · 2024-08-30T17:06:55Z

README.md

+  kick_greedy_cpus=f
+  NODE[00] load=  0.17 imbal=  +0.00 delta=  +0.00
+   DOM[00] load=  0.17 imbal=  +0.00 delta=  +0.00
+###### Thu, 29 Aug 2024 14:42:42 +0200, load balance @ -1268.9ms ######


Would also reduce here the logs, so that the README is not too much filled with logs.

ptr1337

Do we really need to explain from every supported scx scheduler how to use monitor?

I think you could write, which are the supported schedulers and bring one example. instead of showing of every scheduler a example.

htejun · 2024-08-30T17:09:11Z

README.md

@@ -344,6 +344,87 @@ $ cargo install scx_rusty

 and `scx_rusty` will be built and installed as `~/.cargo/bin/scx_rusty`.

+## Checking scx_stats
+
+- To check the scheduler statistics, use the


How about something like:

Most schedulers implement --monitor $INTERVAL which fetches and shows the detailed statistics from the running scheduler. Note that this does not launch the scheduler. The monitoring instance only shows the statistics. Some schedulers may implement different or multiple monitoring options. Refer to --help of each scheduler for details. Most schedulers also accept --stats $INTERVAL to print the statistics directly from the scheduling instance.

Updated, could you take a look now @htejun

Maybe use "statistics" consistently? Schedulers do print out logs like info and warning messages. It just doesn't print out detailed statistics by default.

Done @htejun

sirlucjan · 2024-08-30T17:46:05Z

@ptr1337

Do we really need to explain from every supported scx scheduler how to use monitor?

I think you could write, which are the supported schedulers and bring one example. instead of showing of every scheduler a example.

@multics69 asked about examples.

Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>

arighi · 2024-09-02T12:30:21Z

It looks like we have enough approvals and with scx_rustland also converted to use scx_stats I think we can safely apply this change.

scx_stats: Drop sched-ext namespace

19657d4

Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>

sirlucjan marked this pull request as draft August 27, 2024 16:22

sirlucjan force-pushed the drop-journald branch from ba14d33 to a860997 Compare August 27, 2024 19:03

arighi approved these changes Aug 27, 2024

View reviewed changes

sirlucjan force-pushed the drop-journald branch from a860997 to 0464a1a Compare August 27, 2024 19:23

multics69 self-requested a review August 29, 2024 12:20

multics69 approved these changes Aug 29, 2024

View reviewed changes

Update README.md

e14dae7

Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>

sirlucjan force-pushed the drop-journald branch from c4e6a7f to c338363 Compare August 30, 2024 16:55

ptr1337 reviewed Aug 30, 2024

View reviewed changes

ptr1337 suggested changes Aug 30, 2024

View reviewed changes

htejun reviewed Aug 30, 2024

View reviewed changes

sirlucjan force-pushed the drop-journald branch from c338363 to 729a8cc Compare August 30, 2024 17:31

sirlucjan requested review from htejun, arighi and ptr1337 August 30, 2024 17:32

sirlucjan marked this pull request as ready for review August 30, 2024 17:32

sirlucjan force-pushed the drop-journald branch 2 times, most recently from 5158d14 to ef28c19 Compare August 30, 2024 17:35

Add examples of scx_stats for rusty, rustland, bpfland and lavd

cd8b73a

Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>

sirlucjan force-pushed the drop-journald branch from ef28c19 to cd8b73a Compare August 30, 2024 17:55

arighi merged commit 4fd1ae0 into sched-ext:main Sep 2, 2024
1 check passed

sirlucjan mentioned this pull request Sep 4, 2024

openrc: drop separate logs #607

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

scx_stats: Drop sched-ext namespace #573

scx_stats: Drop sched-ext namespace #573

sirlucjan commented Aug 27, 2024

arighi left a comment

arighi Aug 27, 2024

arighi Aug 27, 2024

multics69 Aug 29, 2024

sirlucjan Aug 29, 2024

sirlucjan commented Aug 27, 2024

sirlucjan commented Aug 29, 2024

arighi commented Aug 29, 2024

sirlucjan commented Aug 29, 2024

ptr1337 Aug 30, 2024

sirlucjan Aug 30, 2024

ptr1337 Aug 30, 2024

sirlucjan Aug 30, 2024

ptr1337 Aug 30, 2024

sirlucjan Aug 30, 2024

ptr1337 left a comment

htejun Aug 30, 2024

sirlucjan Aug 30, 2024

htejun Aug 30, 2024

sirlucjan Aug 30, 2024 •

edited

Loading

sirlucjan commented Aug 30, 2024 •

edited

Loading

arighi commented Sep 2, 2024

		```

		X - for example 1 - this will print the output every second

scx_stats: Drop sched-ext namespace #573

scx_stats: Drop sched-ext namespace #573

Conversation

sirlucjan commented Aug 27, 2024

arighi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sirlucjan commented Aug 27, 2024

sirlucjan commented Aug 29, 2024

arighi commented Aug 29, 2024

sirlucjan commented Aug 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ptr1337 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sirlucjan Aug 30, 2024 • edited Loading

Choose a reason for hiding this comment

sirlucjan commented Aug 30, 2024 • edited Loading

arighi commented Sep 2, 2024

sirlucjan Aug 30, 2024 •

edited

Loading

sirlucjan commented Aug 30, 2024 •

edited

Loading