-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HowTo example uses wrong types for "tool" and "supply" values #1884
Labels
Fixed Awaiting Release
Fixed in main branch / posted to webschemas.org site / proposed for inclusion in next release
Comments
Yes it should be HowToTool of simply text value (HowToSupply too) |
RichardWallis
pushed a commit
that referenced
this issue
Apr 24, 2018
Started to apply these changes and in the process discovered various other errors:
Actions taken:
Also reproduced into RDFa & json-ld formats. Final thought - it potentially would make sense to expand the domain of text to include HowToDirection. |
Merged
RichardWallis
added
the
Fixed Awaiting Release
Fixed in main branch / posted to webschemas.org site / proposed for inclusion in next release
label
Apr 24, 2018
danbri
pushed a commit
that referenced
this issue
Apr 26, 2018
* Issue (#1866): Added reference to cryptocurrencies in description for 'paymentAccepted' & 'currenciesAccepted' properties. For consistency, also added to description of properties: 'discountCurrency', 'price', 'priceCurrency', 'currency'. * Fix typos * Corrections to and added RDFa & json-ld versions to HowTo examples. Issue (#1884). * Reversed some changes not needed Reversed some changes not needed as already visible on webschemas.org eg. HowToSection now a subtype of ListItem, HowToDirection now a subtype of CreativeWork. * Revert "Fix typos" Removing references to issue (#1866) incorrectly added to branch 1884 This reverts commit fc4ea93. * Revert "Issue (#1866): Added reference to cryptocurrencies in description for 'paymentAccepted' & 'currenciesAccepted' properties." This reverts commit 182dd79.
10 tasks
Released in V3.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Fixed Awaiting Release
Fixed in main branch / posted to webschemas.org site / proposed for inclusion in next release
The (mircodata) example on the
HowTo
page uses the wrong types for the value oftool
andsupply
.The
itemtype
fortool
should beHowToTool
; theitemtype
forsupply
should beHowToSupply
The text was updated successfully, but these errors were encountered: