Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HowTo example uses wrong types for "tool" and "supply" values #1884

Closed
Aaranged opened this issue Apr 4, 2018 · 3 comments
Closed

HowTo example uses wrong types for "tool" and "supply" values #1884

Aaranged opened this issue Apr 4, 2018 · 3 comments
Labels
Fixed Awaiting Release Fixed in main branch / posted to webschemas.org site / proposed for inclusion in next release

Comments

@Aaranged
Copy link

Aaranged commented Apr 4, 2018

The (mircodata) example on the HowTo page uses the wrong types for the value of tool and supply.

<div itemprop="tool" itemscope itemtype="http://schema.org/HowToItem">Spare tire</div>
<div itemprop="tool" itemscope itemtype="http://schema.org/HowToItem">Lug wrench</div>
<div itemprop="tool" itemscope itemtype="http://schema.org/HowToItem">Jack</div>
<div itemprop="tool" itemscope itemtype="http://schema.org/HowToItem">Wheel wedges</div>
<div itemprop="supply" itemscope itemtype="http://schema.org/HowToItem">Flares</div>

The itemtype for tool should be HowToTool; the itemtype for supply should be HowToSupply

<div itemprop="tool" itemscope itemtype="http://schema.org/HowToTool">Spare tire</div>
<div itemprop="tool" itemscope itemtype="http://schema.org/HowToTool">Lug wrench</div>
<div itemprop="tool" itemscope itemtype="http://schema.org/HowToTool">Jack</div>
<div itemprop="tool" itemscope itemtype="http://schema.org/HowToTool">Wheel wedges</div>
<div itemprop="supply" itemscope itemtype="http://schema.org/HowToSupply">Flares</div>
@AymenLoukil
Copy link

Yes it should be HowToTool of simply text value (HowToSupply too)

@RichardWallis
Copy link
Contributor

Started to apply these changes and in the process discovered various other errors:

  • Nesting of <div>s incorrect
  • No ordering of ListItems - ItemLists are by default unordered
  • Example used property 'text' not defined for HowToDirection
  • Format of estimatedTime & totalTime properties not correct

Actions taken:

  • Fixed nesting
  • Formatted data for estimatedTime & totalTime properties
  • Replaced text properties with description properties
  • Added positional statements for ordering

Also reproduced into RDFa & json-ld formats.

Final thought - it potentially would make sense to expand the domain of text to include HowToDirection.

@RichardWallis RichardWallis added the Fixed Awaiting Release Fixed in main branch / posted to webschemas.org site / proposed for inclusion in next release label Apr 24, 2018
danbri pushed a commit that referenced this issue Apr 26, 2018
* Issue (#1866): Added reference to cryptocurrencies in description for 'paymentAccepted' & 'currenciesAccepted' properties.
For consistency, also added to description of properties: 'discountCurrency', 'price', 'priceCurrency', 'currency'.

* Fix typos

* Corrections to and added RDFa & json-ld versions to HowTo examples.
Issue (#1884).

* Reversed some changes not needed

Reversed some changes not needed as already visible on webschemas.org eg. HowToSection now a subtype of ListItem, HowToDirection now a subtype of CreativeWork.

* Revert "Fix typos"
Removing references to issue (#1866) incorrectly added to branch 1884
This reverts commit fc4ea93.

* Revert "Issue (#1866): Added reference to cryptocurrencies in description for 'paymentAccepted' & 'currenciesAccepted' properties."

This reverts commit 182dd79.
@RichardWallis
Copy link
Contributor

Released in V3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Awaiting Release Fixed in main branch / posted to webschemas.org site / proposed for inclusion in next release
Projects
None yet
Development

No branches or pull requests

3 participants