New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change redundant 'text' entry to 'name' in ld+json example for Question #1799

Merged
merged 1 commit into from Nov 21, 2017

Conversation

Projects
None yet
4 participants
@fisxoj
Contributor

fisxoj commented Nov 20, 2017

Hello! I did a quick look around for contribution guidelines, and hopefully this is simple enough not to be too much trouble, regardless.

The example for Question had the field text twice. I believe the first entry is supposed to be name, based on the other examples for the same item.

@fisxoj fisxoj changed the title from Change redundant 'text' entry to 'name' in ld+json example to Change redundant 'text' entry to 'name' in ld+json example for Questino Nov 20, 2017

@fisxoj fisxoj changed the title from Change redundant 'text' entry to 'name' in ld+json example for Questino to Change redundant 'text' entry to 'name' in ld+json example for Question Nov 20, 2017

@chaals chaals merged commit 5211bc8 into schemaorg:master Nov 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chaals

This comment has been minimized.

Contributor

chaals commented Nov 21, 2017

Yes, spot on. Thank you!

@fisxoj fisxoj deleted the fisxoj:fix-question-example branch Nov 21, 2017

@ian-axelrod

This comment has been minimized.

ian-axelrod commented Nov 21, 2017

This is a landmark PR. Thank you for all your hard work!!

@gkellogg

This comment has been minimized.

Contributor

gkellogg commented Nov 21, 2017

Note that errors like this are actually detected in Travis-CI: https://travis-ci.org/schemaorg/schemaorg, although these have only been in as unexamined warnings for some time, due to the volume of examples having semantic or syntactic problems (most of the syntactic problems have been found, at least). The idea would be to eventually make errors fail CI, which would prevent a PR from being merged until corrected, and thus not introduce new example errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment