Function number is not working with negative values

[contatolucascosta]

Hi.
I have two examples that the conversion String to Number, is not working good.
I'd like simply convert String to Number, but something i'ts happen and change de value

JSLT INPUT:
{
"value1": -0.2514,
"value2": number("-0.2514"),
"value3": -1.4,
"value4": number("-1.4"),
}

RESPONSE INPUT:
{
"value1" : -0.2514,
"value2" : 0.2514,
"value3" : -1.4,
"value4" : -0.6
}

[larsga]

Thank you very much for finding this bug and reporting it so clearly. This is definitely the most embarrassing bug we've ever had in JSLT. 🤦 It's fixed now. I'll do a full release quite soon so we can get this fix out there.

[contatolucascosta]

Nice!
It's great to see this project it's in continuous evolutions.
Thank you for this fix.

[wang-yutao]

Hello,
I find this bug still exists for negative values within (-1,0).
As number("-0.2514") -> 0.2514 in this example.

[larsga]

OMG. You're right. Will fix.

[larsga]

The problem was that we were storing the sign of the number in intPart, but if the integer part was zero the sign would be lost (🤦). Handled by representing the sign explicitly.

The problem also turned out to exist for numbers like -0.1E2, and that's also solved now.

Should be fixed now, but please do test and verify.

[adippelamount]

@larsga This fix wasn't released to mvn repository, what's the plan on doing that?

[larsga]

I can do a release with that fix. I'll be travelling, but will get it done as soon as I can.

[larsga]

Version 0.1.14 is released now.

[wang-yutao]

Hello,
I still found a problem for numbers like -1E-1, where the part before E is a negative integer.
It will return 0.1 instead of -0.1.

[larsga]

Ouch! You're right. Fixing.