Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify trim() function #69

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Conversation

fredriv
Copy link

@fredriv fredriv commented Apr 1, 2019

Use built in String trim() function

Copy link
Collaborator

@larsga larsga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having thought about it, I think you are right here. We lose a couple of optimizations, but I don't think they are worth the complexity.

Thank you!

@larsga larsga merged commit 8e3d334 into schibsted:master Apr 1, 2019
@fredriv
Copy link
Author

fredriv commented Apr 2, 2019

You're welcome :-) Any plans for when to release a new version of jslt? For now we have added the trim() and replace() functions locally so we can use them already.

@larsga
Copy link
Collaborator

larsga commented Apr 2, 2019

Looking at the log it looks like it's time for a new release. I'll see if I can get one out tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants