Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🗑️ Unused files in WWMIII directory? #58

Closed
jamal919 opened this issue Feb 10, 2022 · 2 comments · Fixed by #59
Closed

🗑️ Unused files in WWMIII directory? #58

jamal919 opened this issue Feb 10, 2022 · 2 comments · Fixed by #59

Comments

@jamal919
Copy link
Member

jamal919 commented Feb 10, 2022 •
edited
Loading

Dear All,

While browsing the code-base, I noticed that there are multiple files in WWMIII directory with _local suffix. The difference between the non-suffixed and suffixed version seems to be the looping over the nodes.

Tracking backward in the codebase, it seems that the WWM module used with schism does not contain reference to these files. Yet, they are added in CMakeLists.txt as well as the top-level Makefile.

For further check - I had removed the reference to these _local files from CMakeLists.txt and compiled schism-WWM - which went fine.

The files in question are following -

wwm_airsea_local.F90
wwm_ecmwf_local.F90
wwm_femean_local.F90
wwm_femeanws_local.F90
wwm_fkmean_local.F90
wwm_frcutindex_local.F90
wwm_implsch2_local.F90
wwm_implsch_local.F90
wwm_sbottom_local.F90
wwm_sdiss_ardh_vec_local.F90
wwm_sdissip_local.F90
wwm_sinput_ard_local.F90
wwm_sinput_local.F90
wwm_snonlin_local.F90
wwm_st4_local.F90
wwm_st6_local.F90
wwm_stresso_local.F90
wwm_wsigstar_local.F90

Additionally, there are some files called 2do, forchk_*, gap.dat, PFMODULE.KEY, syserg.bin that I did not find reference to code.

Furthermore, there seems to be some leftover runtime files - windbg_0000, wwmdbg_0000, wwmstat_0000 in the folder.

Are these files actually used? If not, then removing these codes might improve the clarity of the code-dir structure.

I am also curious if WWM still compiles by itself, through the makefile inside the WWMIII folder. It looks like the makefiles looks for some elfe_ dependency which does not exist anymore.

Thanks.
@jamal919 jamal919 changed the title 🗑️ Unused files in WWM? 🗑️ Unused files in WWMIII directory? Feb 10, 2022
@josephzhang8
Copy link
Member

josephzhang8 commented Feb 10, 2022 via email

@jamal919 jamal919 mentioned this issue Feb 10, 2022
Merged
@jamal919
Copy link
Member Author

Thanks @josephzhang8 , I have created PR #59 for further discussion.

@jamal919 jamal919 mentioned this issue Sep 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

⚰️ Removes unused files in WWMIII jamal919/schism
2 participants
@jamal919 @josephzhang8