Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CONTRIBUTING #5

Merged
merged 4 commits into from
Sep 9, 2019
Merged

Create CONTRIBUTING #5

merged 4 commits into from
Sep 9, 2019

Conversation

jamal919
Copy link
Member

@jamal919 jamal919 commented Sep 8, 2019

Added a markdown copy of git-cheat

Added a markdown copy of git-cheat
@jreniel
Copy link
Member

jreniel commented Sep 8, 2019

Can we all take a look at this and approve/suggest edits? @josephzhang8 @water-e

@jamal919 can you add your squash suggestion to the file?

@jreniel jreniel added the documentation Improvements or additions to documentation label Sep 8, 2019
Update markdown, added --squash merge commands
Command markdown is edited to be able to render them properly in a browser
@jamal919
Copy link
Member Author

jamal919 commented Sep 9, 2019

Following changes -

  1. CONTRIBUTING is renamed to CONTRIBUTING.md so that markdown is displayed in github
  2. merge --squash is added
  3. Markdown for the terminal commands are added

This branch has no conflit with the base branch - so should be straightforward to merge once everyone agrees.

I am not able to merge it, as github is showing me that I do not have write access to merge this pull request.

Thanks.

Added markdown for codeblocks
@jreniel
Copy link
Member

jreniel commented Sep 9, 2019

@jamal919 You should have write permissions now. Try again so we can confirm.

@jamal919 jamal919 merged commit 00f321b into schism-dev:master Sep 9, 2019
@jamal919 jamal919 deleted the patch-1 branch September 9, 2019 12:39
@jamal919
Copy link
Member Author

jamal919 commented Sep 9, 2019

Squash and merged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants