Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buttons hover effect #263

Conversation

lucasferrazlima
Copy link

@lucasferrazlima lucasferrazlima commented Feb 1, 2024

It appears that the bug is resolved by removing the z-index: -1 line.

I've made tests on both Chrome and Firefox, and the hover effect is now functioning correctly without any observed side effects.

issue link: #262 #296

image

@schlagmichdoch
Copy link
Owner

Thanks for your contribution! I have already fixed the issue in another branch though as this was rather a todo issue..
By applying the z-index: -1 to the .icon-buttons only the header buttons have the hover effect in the background and all other buttons have it in the foreground

@schlagmichdoch
Copy link
Owner

Thanks for testing though! I will add you as co-author to the commit :)

@lucasferrazlima
Copy link
Author

Thank you for considering my contribution, and I'm glad to hear that the issue is resolved!
I appreciate your effort in maintaining this project.

schlagmichdoch added a commit that referenced this pull request Feb 9, 2024
## Enhancements
- Implemented drag and drop into text fields
- Tidy up code
- Translations update from Hosted Weblate (Italian)

## Fixes
- Received URLs with single letter subdomains not hydrated into links #258
- Button does not change color on hover (#262 + #263)
- On Windows Edge, PeerUI shows „preparing“ when file selector is cancelled (#257)
@schlagmichdoch schlagmichdoch changed the title Fix buttons hover effect - issue #262 Fix buttons hover effect - issue ~~#262~~ #296 Apr 30, 2024
@schlagmichdoch schlagmichdoch changed the title Fix buttons hover effect - issue ~~#262~~ #296 Fix buttons hover effect Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants