Allow missing attributes in serialized objects #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbabker
reviewed
Dec 4, 2023
boesing
force-pushed
the
bugfix/missing-attributes
branch
from
1b0ec05
to
38bb263
Compare
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
boesing
force-pushed
the
bugfix/missing-attributes
branch
from
38bb263
to
545f455
Compare
mbabker
approved these changes
Dec 5, 2023
scyzoryck
reviewed
Dec 5, 2023
The attribute is missing on purpose and therefore, ignoring that error should be legit. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
boesing
force-pushed
the
bugfix/missing-attributes
branch
from
20395ca
to
e0fd33c
Compare
|
I hope I managed the phpstan configuration part correctly but from how I understand that issue, the changes should solve that problem. I also added missing annotation to the fixture so that both metadata parser can extract the |
scyzoryck
reviewed
Dec 9, 2023
|
Thanks for contribution! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1525 which points to some kind of BC break in v3.28.0 regarding missing attributes.