feat: expose guest password on switch #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a card to the dashboard that shows the QR code but also shows the SSID & Password for the guest account (allows guest to login w/ a laptop), to facilitate this I needed to add the guest password to the guest switch (that was the easiest as the name was already there).
I don't think there's any security concern with this as the integration is already producing the QR code which has the same information (or at least it is retrievable).
Thanks for the integration -- I started down the path myself before realizing you'd already built 95% of what I was looking for -- I've gotta remind myself to google first 🤦