Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nft viewer background issues #4

Merged
merged 9 commits into from
Apr 19, 2022
Merged

fix nft viewer background issues #4

merged 9 commits into from
Apr 19, 2022

Conversation

koteakhaladze
Copy link
Contributor

No description provided.

@koteakhaladze koteakhaladze changed the base branch from main to schnoodle-nft April 11, 2022 09:48
NeoXtreem
NeoXtreem reviewed Apr 11, 2022
View reviewed changes
Copy link
Member

@NeoXtreem NeoXtreem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, how does the reference project do this with the .vert and .frag files directly instead of compiling to .js files?

NeoXtreem
NeoXtreem requested changes Apr 19, 2022
View reviewed changes
Copy link
Member

@NeoXtreem NeoXtreem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good now. Just a couple of minor tweaks.

SchnoodleDApp/ClientApp/package.json Show resolved Hide resolved
@NeoXtreem NeoXtreem merged commit d68c455 into schnoodle-nft Apr 19, 2022
@NeoXtreem NeoXtreem deleted the schnoodle-nft-kote branch April 19, 2022 12:59
@NeoXtreem NeoXtreem mentioned this pull request May 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeoXtreem NeoXtreem NeoXtreem requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koteakhaladze @NeoXtreem