feature/allow-custom-spinners #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schollz
requested changes
Jan 3, 2023
This reverts commit 87c9df0.
…is used at a time
kodiakhq bot
referenced
this pull request
in cloudquery/plugin-sdk
Feb 1, 2023
…#646) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/schollz/progressbar/v3](https://togithub.com/schollz/progressbar) | require | minor | `v3.12.2` -> `v3.13.0` | --- ### Release Notes <details> <summary>schollz/progressbar</summary> ### [`v3.13.0`](https://togithub.com/schollz/progressbar/releases/tag/v3.13.0) [Compare Source](https://togithub.com/schollz/progressbar/compare/v3.12.2...v3.13.0) #### What's Changed - feature/allow-custom-spinners by [@​nilsbeck](https://togithub.com/nilsbeck) in [https://github.com/schollz/progressbar/pull/151](https://togithub.com/schollz/progressbar/pull/151) #### New Contributors - [@​nilsbeck](https://togithub.com/nilsbeck) made their first contribution in [https://github.com/schollz/progressbar/pull/151](https://togithub.com/schollz/progressbar/pull/151) **Full Changelog**: schollz/progressbar@v3.12.2...v3.13.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45NC4wIiwidXBkYXRlZEluVmVyIjoiMzQuOTQuMCJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new option to use custom spinners by passing in a
[]stringintoOptionSpinnerCustom. This allows to use other spinners than one of the 76 preset spinners.It also returns an
errorin theAddfunc if both options are used. This is not ideal and the correct place would be to make the Option return an error and check this error when creating a new Bar. But since this is also a breaking change (then we have 2 return params) I did not go down that road.