Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/allow-custom-spinners #151

Merged
merged 9 commits into from Jan 5, 2023

Conversation

nilsbeck
Copy link
Contributor

@nilsbeck nilsbeck commented Dec 18, 2022

Description

This PR adds a new option to use custom spinners by passing in a []string into OptionSpinnerCustom. This allows to use other spinners than one of the 76 preset spinners.
It also returns an error in the Add func if both options are used. This is not ideal and the correct place would be to make the Option return an error and check this error when creating a new Bar. But since this is also a breaking change (then we have 2 return params) I did not go down that road.

progressbar.go Outdated Show resolved Hide resolved
@schollz schollz merged commit a307e8c into schollz:main Jan 5, 2023
kodiakhq bot pushed a commit to cloudquery/plugin-sdk that referenced this pull request Feb 1, 2023
…#646)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/schollz/progressbar/v3](https://togithub.com/schollz/progressbar) | require | minor | `v3.12.2` -> `v3.13.0` |

---

### Release Notes

<details>
<summary>schollz/progressbar</summary>

### [`v3.13.0`](https://togithub.com/schollz/progressbar/releases/tag/v3.13.0)

[Compare Source](https://togithub.com/schollz/progressbar/compare/v3.12.2...v3.13.0)

#### What's Changed

-   feature/allow-custom-spinners by [@&#8203;nilsbeck](https://togithub.com/nilsbeck) in [schollz/progressbar#151

#### New Contributors

-   [@&#8203;nilsbeck](https://togithub.com/nilsbeck) made their first contribution in [schollz/progressbar#151

**Full Changelog**: schollz/progressbar@v3.12.2...v3.13.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45NC4wIiwidXBkYXRlZEluVmVyIjoiMzQuOTQuMCJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants