Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix data race in Describe #153

Merged
merged 1 commit into from
Mar 14, 2023
Merged

fix data race in Describe #153

merged 1 commit into from
Mar 14, 2023

Conversation

kemingy
Copy link
Contributor

@kemingy kemingy commented Feb 2, 2023

Signed-off-by: Keming kemingy94@gmail.com

Since render is not thread-safe, and Describe is provided to update the description.

Signed-off-by: Keming <kemingy94@gmail.com>
@schollz
Copy link
Owner

schollz commented Mar 14, 2023

Thanks!

@schollz schollz merged commit b6e5a4b into schollz:main Mar 14, 2023
@kemingy kemingy deleted the fix_race branch March 14, 2023 13:54
kodiakhq bot referenced this pull request in cloudquery/plugin-sdk Apr 1, 2023
…#750)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/schollz/progressbar/v3](https://togithub.com/schollz/progressbar) | require | patch | `v3.13.0` -> `v3.13.1` |

---

### Release Notes

<details>
<summary>schollz/progressbar</summary>

### [`v3.13.1`](https://togithub.com/schollz/progressbar/releases/tag/v3.13.1)

[Compare Source](https://togithub.com/schollz/progressbar/compare/v3.13.0...v3.13.1)

#### What's Changed

-   fix: remove github.com/rivo/uniseg from go.mod to fix go version by [@&#8203;DarthPestilane](https://togithub.com/DarthPestilane) in [https://github.com/schollz/progressbar/pull/158](https://togithub.com/schollz/progressbar/pull/158)
-   remove duplicate call of term.GetSize by [@&#8203;talwat](https://togithub.com/talwat) in [https://github.com/schollz/progressbar/pull/156](https://togithub.com/schollz/progressbar/pull/156)
-   fix data race in `Describe` by [@&#8203;kemingy](https://togithub.com/kemingy) in [https://github.com/schollz/progressbar/pull/153](https://togithub.com/schollz/progressbar/pull/153)

#### New Contributors

-   [@&#8203;DarthPestilane](https://togithub.com/DarthPestilane) made their first contribution in [https://github.com/schollz/progressbar/pull/158](https://togithub.com/schollz/progressbar/pull/158)
-   [@&#8203;talwat](https://togithub.com/talwat) made their first contribution in [https://github.com/schollz/progressbar/pull/156](https://togithub.com/schollz/progressbar/pull/156)
-   [@&#8203;kemingy](https://togithub.com/kemingy) made their first contribution in [https://github.com/schollz/progressbar/pull/153](https://togithub.com/schollz/progressbar/pull/153)

**Full Changelog**: schollz/progressbar@v3.13.0...v3.13.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTkuMiIsInVwZGF0ZWRJblZlciI6IjM0LjE1OS4yIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants